1623370 - Error upgrading moz-phab on Windows but it still works

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Mike Kaply [:mkaply]]

I got the following when starting moz-phab on Win10:

$ moz-phab
Upgrading to version 0.1.80
Collecting MozPhab
  Downloading https://files.pythonhosted.org/packages/6a/1a/fabaca08b569aef585d6da6ba44066dcebe05219bf77d29e5f92ec3ea70f/MozPhab-0.1.80.tar.gz (60kB)
     |████████████████████████████████| 61kB 3.8MB/s
Requirement already satisfied, skipping upgrade: sentry-sdk in c:\mozilla-build\python3\lib\site-packages (from MozPhab) (0.14.1)
Requirement already satisfied, skipping upgrade: setuptools in c:\mozilla-build\python3\lib\site-packages (from MozPhab) (41.4.0)
Requirement already satisfied, skipping upgrade: certifi in c:\mozilla-build\python3\lib\site-packages (from sentry-sdk->MozPhab) (2019.11.28)
Requirement already satisfied, skipping upgrade: urllib3>=1.10.0 in c:\mozilla-build\python3\lib\site-packages (from sentry-sdk->MozPhab) (1.25.8)
Installing collected packages: MozPhab
  Found existing installation: MozPhab 0.1.79
    Uninstalling MozPhab-0.1.79:
      Successfully uninstalled MozPhab-0.1.79
    Running setup.py install for MozPhab ... done
Successfully installed MozPhab-0.1.80
Restarting...
c:\mozilla-build\python3\python3.exe: can't open file 'c:\mozilla-build\python3\Scripts\moz-phab': [Errno 2] No such file or directory
CommandError: command 'c:\mozilla-build\python3\python3.exe' failed to complete successfully
Run moz-phab again with '--trace' to show the stack trace
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-Break to quit

But the upgrade did succeed. I was immediately able to run the new moz-phab. From conversation on #phabricator:

@mhentges that's a different error. note mkaply's error is missing a .exe extension
which may or may not be the problem
yeah, looking at the code that's totally wrong for windows
moz-phab.exe exists in the Scripts dir, not moz-phab. so on windows we need to run that directly instead of sys.executable

Comment 1

[:glob ✱]

thanks; i'll look at this tomorrow.

Comment 2

[:glob ✱]

Attachment: Bug 1623370 - Fix restarting after an automatic update on Windows; r=zalun

Comment 3

[:glob ✱]

https://github.com/mozilla-conduit/review/commit/3ecf4164fae7c6706231e70d8634213f32e16007