Open Bug 1623549 Opened 5 years ago Updated 2 years ago

Fetching all breakpoint positions for a single line is too slow/janky for minified files

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(Not tracked)

People

(Reporter: loganfsmyth, Unassigned)

References

(Blocks 1 open bug)

Details

We currently have two different codepaths for handling breakpoint positions for files, one that is line-based, and one that is range-based: https://searchfox.org/mozilla-central/rev/61f224ec08ddc6f9a93ac45c8c3c5f7159be7c2a/devtools/client/debugger/src/actions/breakpoints/breakpointPositions.js#116

The line-based approach for generated files has proven to be too janky for minified files with breakpoints and we should explore using a range-based approach for generated files as well.

Adding breakpoints directly to a large minified file isn't exactly a common usecase since people tend to prettify files before debugging in that context, but as seen in https://bugzilla.mozilla.org/show_bug.cgi?id=1621819, this can still cause issues on page refresh because we'll reload the source and we want to re-apply breakpoints immediately on the generated file, which can potentially cause us to load all of the breakpoint position data for the one huge line with all the code and thus positions on it.

No longer blocks: 1621819
Blocks: 1621819

The priority flag is not set for this bug.
:jlast, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jlaster)

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Severity: normal → S3
Flags: needinfo?(jlaster)
See Also: → 1819282
You need to log in before you can comment on or make changes to this bug.