1623628 - Remove the command-line switch (and any about:config option) for bigint<->int64

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P1)

Description

[Lars T Hansen [:lth]]

I don't think this switch is meaningful any longer. We want the feature to be enabled, and it's currently enabled in shell and Nightly. The feature does not impact anything else, in particular, enabling it does not disable any compiler, so there's no utility in having a switch to run-time disable the feature.

(I need to find out why this feature is not moving to phase 4 in the CG, since it seems "done" and we could ship it even with the ion->wasm fast path.)

Comment 1

[Asumu Takikawa]

Attachment: Bug 1623628 - part 1, remove compile-time and run-time flags for BigInt/I64 conversion in Wasm

This patch removes the compile-time and run-time flags that disable BigInt/I64 so that the feature can be shipped. It also adjusts/removes tests as appropriate to account for the removed code paths.

Comment 2

[Asumu Takikawa]

Attachment: Bug 1623628 - part 2, remove compile-time and run-time flags for BigInt/I64 conversion in Wasm

This patch adjusts the WebAssembly web platform test metadata to account for BigInt/I64 conversion being enabled without flags.

This metadata will need adjustment once the proposal's tests are merged into the web platform tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08e46e5350e2
part 1, remove compile-time and run-time flags for BigInt/I64 conversion in Wasm r=wingo,lth
https://hg.mozilla.org/integration/autoland/rev/64922f64fe23
part 2, remove compile-time and run-time flags for BigInt/I64 conversion in Wasm r=wingo,lth

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/08e46e5350e2
https://hg.mozilla.org/mozilla-central/rev/64922f64fe23