162367 - After clicking a folder on the bookmarks toolbar, double-clicking anywhere recalls the pop-up menu

Status: VERIFIED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Derek Schrock]

After you click on a folder that's in your bookmarks toolbar a double click
anywhere else on the browser window will reproduce the floating menu.

Steps:
1) Click on a folder in your bookmarks toolbar
2) double click anywhere on the browser window

Comment 1

[Greg K.]

Confirmed using Chimera/2002081105. Reassigning to Toolbars & Menus.

Comment 2

[saari (gone)]

->pinkerton

Comment 3

[Mike Pinkerton (not reading bugmail)]

neat. max, any ideas?

Comment 4

[Max Horn]

I don't quite understand what is meant heree - what does "reproduce the 
floating menu" mean?

In my own build, nothing unusual seems to happen, but then I have 
applied various patches, most importantly the patch attached to bug 
#149836 which might affect this.

Comment 5

[Max Horn]

Gah! Being able to read helps a lot, this was talking about the *
bookmarks toolbar*, please ignore me :-)

Yes I see the problem, and I will look into it.

Comment 6

[Max Horn]

Attachment: Fix

Fix for the issue. Explanation:

We overwrite mouseDown to display a custom popup menu for folders in the
bookmark toolbar (note that mouseUp for NSButtons is never called, because the
default mouseDown method of NSControl does not return before the mouseUp,
normally).
Now, this menu is displayed using [NSMenu popUpContextMenu]. When you click
outside the menu, the menu will close (the first click of our double click). It
takes it a little moment to fade out. When you quickly click again in this
period, the second mouseDown event is routed to the NSButton, even though the
mouse is not over it, and thus it reopens the menu. 

A proper fix might be to check again if the click was inside the button in
mouseDown, but this hack just ensures that the menu is only triggered by single
clicks, which gives exactly the same resuls in this case.

Comment 7

[Mike Pinkerton (not reading bugmail)]

thx max. landed.

Comment 8

[Chris Petersen]

Verified in the 2002-08-21-05 NB.