Closed Bug 1623770 Opened 2 months ago Closed 1 month ago

Crash in [@ __memcpy_sse2_unaligned_erms | ChunkedJSONWriteFunc::CopyDataIntoLazilyAllocatedBuffer]

Categories

(Core :: Gecko Profiler, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- unaffected
firefox76 --- wontfix
firefox77 --- fixed

People

(Reporter: mccr8, Assigned: canova)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug is for crash report bp-689ca3f6-aa1f-423c-967f-a2b680200319.

Top 10 frames of crashing thread:

0 libc-2.27.so __memcpy_sse2_unaligned_erms 
1 libxul.so ChunkedJSONWriteFunc::CopyDataIntoLazilyAllocatedBuffer const tools/profiler/core/ProfileJSONWriter.cpp:54
2 libxul.so profiler_get_profile_json_into_lazily_allocated_buffer tools/profiler/core/platform.cpp:3825
3 libxul.so mozilla::ProfilerChild::RecvGatherProfile tools/profiler/gecko/ProfilerChild.cpp:89
4 libxul.so mozilla::PProfilerChild::OnMessageReceived ipc/ipdl/PProfilerChild.cpp:252
5 libxul.so mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2187
6 libxul.so mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1990
7 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1220
8 libxul.so mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:332
9 libxul.so MessageLoop::Run ipc/chromium/src/base/message_loop.cc:290

Priority: -- → P1

https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/tools/profiler/core/ProfileJSONWriter.cpp#51,54
I'm suspecting that ptr is null (probable OOM), we should check it before using it.

I have the odd feeling that I recently reviewed code that did just that! Nazim, was that yours?

Flags: needinfo?(canaltinova)

Yeah it looks like we failed to allocate a memory there. I don't remember having a patch, but I can write a quick fix.

Flags: needinfo?(canaltinova)
Assignee: nobody → canaltinova
Status: NEW → ASSIGNED
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3c419a37f51b
Return early if failed to allocate a memory in CopyDataIntoLazilyAllocatedBuffer. r=gerald
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.