1623770 - Crash in [@ __memcpy_sse2_unaligned_erms | ChunkedJSONWriteFunc::CopyDataIntoLazilyAllocatedBuffer]

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P1)

Description

[Andrew McCreight [:mccr8]]

This bug is for crash report bp-689ca3f6-aa1f-423c-967f-a2b680200319.

Top 10 frames of crashing thread:

0 libc-2.27.so __memcpy_sse2_unaligned_erms 
1 libxul.so ChunkedJSONWriteFunc::CopyDataIntoLazilyAllocatedBuffer const tools/profiler/core/ProfileJSONWriter.cpp:54
2 libxul.so profiler_get_profile_json_into_lazily_allocated_buffer tools/profiler/core/platform.cpp:3825
3 libxul.so mozilla::ProfilerChild::RecvGatherProfile tools/profiler/gecko/ProfilerChild.cpp:89
4 libxul.so mozilla::PProfilerChild::OnMessageReceived ipc/ipdl/PProfilerChild.cpp:252
5 libxul.so mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2187
6 libxul.so mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1990
7 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1220
8 libxul.so mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:332
9 libxul.so MessageLoop::Run ipc/chromium/src/base/message_loop.cc:290

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/tools/profiler/core/ProfileJSONWriter.cpp#51,54
I'm suspecting that ptr is null (probable OOM), we should check it before using it.

I have the odd feeling that I recently reviewed code that did just that! Nazim, was that yours?

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Yeah it looks like we failed to allocate a memory there. I don't remember having a patch, but I can write a quick fix.

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1623770 - Return early if failed to allocate a memory in CopyDataIntoLazilyAllocatedBuffer. r?gerald

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c419a37f51b
Return early if failed to allocate a memory in CopyDataIntoLazilyAllocatedBuffer. r=gerald

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3c419a37f51b