1623778 - Crash in [@ std::io::stdio::_eprint] during fluent_bundle_add_resource

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

This bug is for crash report bp-04eec468-2c3b-4df8-b93a-af5a70200317.

Top 10 frames of crashing thread:

0 libxul.so RustMozCrash mozglue/static/rust/wrappers.cpp:17
1 libxul.so mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 libxul.so core::ops::function::Fn::call src/libcore/ops/function.rs:72
3 libxul.so std::panicking::rust_panic_with_hook src/libstd/panicking.rs:475
4 libxul.so rust_begin_unwind src/libstd/panicking.rs:375
5 libxul.so std::panicking::begin_panic_fmt src/libstd/panicking.rs:326
6 libxul.so std::io::stdio::_eprint src/libstd/io/stdio.rs:811
7 libxul.so fluent_bundle_add_resource intl/l10n/rust/fluent-ffi/src/bundle.rs:254
8 libxul.so mozilla::dom::FluentBundle_Binding::addResource dom/bindings/FluentBinding.cpp:1000
9 libxul.so bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3205

This crash is happening on the line eprintln!("Error while adding a resource");.

I don't know why the signature is so crummy. A lot of the recent crashes with this signature are this issue, but maybe not all of them. I filed bug 1623774 about the signature.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Emilio - any idea why this crashes and what would be a safe way to report errors?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yeah, the error message says it... it's crashing with "os error 5", which is access denied.

Either let _ = writeln!(&mut io::stderr(), "..."); to ignore the error, or use the log crate, or even better in this case return the error to C++ and throw an exception?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(Or log a warning in the console or something)

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1623778 - Improve error reporting for AddResource. r?emilio

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

This is a temporary solution. Once I migrate Localization.jsm to Rust I'll unify error reporting to happen in Localization class and bind them to contexts and file URIs.
Also, in Localization warnings are shown in testing and local builds, CI is meant to crash, and production stable release builds not show recoverable errors.

For now, this will help people discover error scenarios.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41722eea7dd5
Improve error reporting for AddResource. r=emilio

Comment 7

[Alexandru Michis [:malexandru]]

Backed out changeset 41722eea7dd5 for causing failures in l10n/test/mochitest/localization/test_format

Backout link: https://hg.mozilla.org/integration/autoland/rev/de570852a84cb0b5f16f97341da84d89f0b33dc7

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=de570852a84cb0b5f16f97341da84d89f0b33dc7&fromchange=41722eea7dd55ef5e59fbf80841f1c5561dab753&selectedJob=294163032

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294163032&repo=autoland&lineNumber=9150

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da4e0b4b9306
Improve error reporting for AddResource. r=emilio

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

minor test incompatibility due to error strings.

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/da4e0b4b9306