1623793 - Disable AudioIPC on 32-bit Windows in beta

Status: VERIFIED FIXED

(Core :: Audio/Video: cubeb, task, P1)

Description

[Matthew Gregan [:kinetik]]

Bug 1621360 and bug 1622931 have shown up in beta while AudioIPC for Windows rides the trains. I have an unconfirmed fix for bug 1621360 but bug 1622931 is not yet understood. The crash rate from these issues is too high to ship with, so disabling the feature until we have fixes in hand is the best current option.

Also see https://bugzilla.mozilla.org/show_bug.cgi?id=1621360#c9

Comment 1

[Matthew Gregan [:kinetik]]

Clarifying bug title: the intention is to disable in beta and leave enabled in nightly.

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Bug 1623793 - Disable AudioIPC on 32-bit Windows in beta. r?chunmin

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 9134565 [details]
Bug 1623793 - Disable AudioIPC on 32-bit Windows in beta. r?chunmin

Beta/Release Uplift Approval Request

• User impact if declined: 32-bit Windows users may crash when using audio due to bug 1621360 or bug 1622931.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk - feature disabled via pref change.
• String changes made/needed: n/a

Comment 4

[Julien Cristau [:jcristau]]

Comment on attachment 9134565 [details]
Bug 1623793 - Disable AudioIPC on 32-bit Windows in beta. r?chunmin

approved for 75.0b7

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e331898dbb06

Comment 6

[Raluca Popovici, Desktop QA]

Hi,
Matthew, can you please tell me which pref should be verified because I can't find anything in about:config.
Thank you!

Comment 7

[Julien Cristau [:jcristau]]

The pref is media.cubeb.sandbox

Comment 8

[Raluca Popovici, Desktop QA]

The pref "media.cubeb.sandbox" is true for:

1. Win 10x64 on Fx75x64b and Fx76x64
2. Win 10x32 on Fx76x32b
3. Win 8.1x32 on Fx76x32b
4. Win 7x32 on Fx76x32b

Verified - Fixed(pref "media.cubeb.sandbox" is false) in Firefox Beta 75.0b7 x32b on Win 10, Win 8.1, Win 7(32-bit).

Thank you Julien.