Closed Bug 1623849 Opened 6 years ago Closed 5 years ago

2.39 - 42.48% raptor-tp6 (linux64-shippable, linux64-shippable-qr, macosx1014-64-shippable, windows10-64-shippable, windows10-64-shippable-qr, windows7-32-shippable) regression on push 06a61ba9c44415c7e84eb2c1548f53a95bd651e0 (Tue March 17 2020)

Categories

(Core :: DOM: Navigation, defect, P2)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- unaffected
firefox75 --- unaffected
firefox76 blocking fixed
firefox77 --- fixed

People

(Reporter: Bebe, Assigned: mattwoodrow)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression)

Attachments

(1 file)

Bug 1623849 - Stop DocumentLoadListener from copying INHIBIT_PERSISTENT_CACHING to the content process channel. r?mayhemer
47 bytes, text/x-phabricator-request
ryanvm
: approval-mozilla-beta+
Details | Review

Raptor has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=06a61ba9c44415c7e84eb2c1548f53a95bd651e0

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

42% raptor-tp6-pinterest-firefox-cold fcp windows10-64-shippable-qr opt 564.54 -> 804.33
37% raptor-tp6-twitter-firefox-cold fcp linux64-shippable opt 593.00 -> 811.08
36% raptor-tp6-twitter-firefox-cold fcp linux64-shippable-qr opt 593.58 -> 809.83
33% raptor-tp6-twitter-firefox-cold fcp windows7-32-shippable opt 571.00 -> 760.67
33% raptor-tp6-twitter-firefox-cold fcp windows10-64-shippable-qr opt 538.42 -> 716.42
32% raptor-tp6-pinterest-firefox-cold fcp linux64-shippable opt 655.42 -> 866.58
30% raptor-tp6-pinterest-firefox-cold fcp windows7-32-shippable opt 596.33 -> 774.58
30% raptor-tp6-pinterest-firefox-cold fcp linux64-shippable-qr opt 673.42 -> 872.08
26% raptor-tp6-pinterest-firefox-cold linux64-shippable-qr opt 907.90 -> 1,145.80
25% raptor-tp6-pinterest-firefox-cold linux64-shippable opt 902.04 -> 1,127.25
24% raptor-tp6-pinterest-firefox-cold linux64-shippable opt 913.99 -> 1,136.43
24% raptor-tp6-pinterest-firefox-cold windows10-64-shippable opt 866.00 -> 1,076.42
24% raptor-tp6-twitter-firefox-cold fcp macosx1014-64-shippable opt 873.50 -> 1,083.33
23% raptor-tp6-pinterest-firefox-cold windows10-64-shippable-qr opt 840.98 -> 1,037.25
21% raptor-tp6-pinterest-firefox-cold fcp macosx1014-64-shippable opt 1,076.50 -> 1,305.58
17% raptor-tp6-pinterest-firefox-cold windows7-32-shippable opt 861.03 -> 1,005.31
13% raptor-tp6-office-firefox-cold fcp linux64-shippable-qr opt 447.25 -> 506.33
13% raptor-tp6-pinterest-firefox-cold loadtime linux64-shippable opt 1,897.58 -> 2,146.17
13% raptor-tp6-pinterest-firefox-cold macosx1014-64-shippable opt 1,425.27 -> 1,606.14
13% raptor-tp6-office-firefox-cold fcp linux64-shippable opt 449.29 -> 505.50
12% raptor-tp6-pinterest-firefox-cold loadtime linux64-shippable-qr opt 1,945.42 -> 2,180.75
11% raptor-tp6-twitter-firefox-cold linux64-shippable opt 733.42 -> 813.41
10% raptor-tp6-pinterest-firefox-cold loadtime windows7-32-shippable opt 1,778.33 -> 1,947.42
9% raptor-tp6-twitter-firefox-cold windows7-32-shippable opt 681.64 -> 746.34
9% raptor-tp6-office-firefox-cold linux64-shippable opt 463.56 -> 507.17
9% raptor-tp6-pinterest-firefox-cold loadtime windows10-64-shippable-qr opt 1,788.58 -> 1,956.00
9% raptor-tp6-pinterest-firefox-cold loadtime windows10-64-shippable opt 1,816.17 -> 1,980.00
9% raptor-tp6-office-firefox-cold linux64-shippable-qr opt 460.98 -> 502.42
9% raptor-tp6-microsoft-firefox-cold linux64-shippable opt 544.82 -> 591.46
8% raptor-tp6-microsoft-firefox-cold fcp linux64-shippable opt 489.17 -> 529.58
8% raptor-tp6-microsoft-firefox-cold loadtime linux64-shippable opt 832.12 -> 898.00
7% raptor-tp6-microsoft-firefox-cold fcp windows10-64-shippable opt 449.50 -> 482.83
7% raptor-tp6-microsoft-firefox-cold fcp windows7-32-shippable opt 454.33 -> 487.50
6% raptor-tp6-microsoft-firefox-cold fcp windows10-64-shippable-qr opt 510.25 -> 542.58
6% raptor-tp6-microsoft-firefox-cold windows7-32-shippable opt 473.08 -> 502.28
6% raptor-tp6-microsoft-firefox-cold linux64-shippable-qr opt 555.89 -> 590.04
6% raptor-tp6-microsoft-firefox-cold fcp linux64-shippable-qr opt 546.67 -> 579.58
6% raptor-tp6-microsoft-firefox-cold windows10-64-shippable opt 470.80 -> 498.60
5% raptor-tp6-netflix-firefox-cold fcp linux64-shippable opt 579.08 -> 607.42
5% raptor-tp6-microsoft-firefox-cold windows10-64-shippable-qr opt 479.68 -> 502.08
4% raptor-tp6-netflix-firefox-cold linux64-shippable opt 761.91 -> 796.02
4% raptor-tp6-netflix-firefox-cold windows10-64-shippable-qr opt 729.32 -> 758.55
4% raptor-tp6-netflix-firefox-cold fcp windows10-64-shippable opt 553.88 -> 573.83
3% raptor-tp6-netflix-firefox-cold windows10-64-shippable opt 717.51 -> 739.48
3% raptor-tp6-sheets-firefox-cold fcp linux64-shippable opt 768.62 -> 789.42
2% raptor-tp6-sheets-firefox-cold linux64-shippable opt 904.98 -> 926.64

Improvements:

48% raptor-tp6-twitter-firefox-cold loadtime macosx1014-64-shippable opt 2,353.17 -> 1,231.08
45% raptor-tp6-twitter-firefox-cold loadtime windows10-64-shippable opt 1,468.42 -> 813.00
43% raptor-tp6-twitter-firefox-cold loadtime windows7-32-shippable opt 1,448.33 -> 828.42
42% raptor-tp6-twitter-firefox-cold loadtime linux64-shippable-qr opt 1,567.25 -> 904.58
42% raptor-tp6-twitter-firefox-cold loadtime linux64-shippable opt 1,565.25 -> 909.33

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=25452

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a Treeherder page showing the Raptor jobs in a pushlog format.

To learn more about the regressing test(s) or reproducing them, please see: https://wiki.mozilla.org/TestEngineering/Performance/Raptor

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/TestEngineering/Performance/Talos/RegressionBugsHandling

Component: Performance → DOM: Navigation
Flags: needinfo?(matt.woodrow)
Product: Testing → Core
Version: Version 3 → unspecified

This seems like a regression we wouldn't want to ship 76 with. Bumping to blocker status.

Severity: normal → critical
tracking-firefox76: + → blocking

The regressing change here just added some filtering to the notifications the content process sends to the frontend, so shouldn't be real load time regressions.

I'll try dig into what raptor is looking at that could be affected by this.

Assignee: nobody → matt.woodrow
Flags: needinfo?(matt.woodrow)

Hi Matt, are you able to assign this a priority now? Thank you!

Flags: needinfo?(matt.woodrow)
Flags: needinfo?(matt.woodrow)
Priority: -- → P2
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2800984d36d6 Stop DocumentLoadListener from copying INHIBIT_PERSISTENT_CACHING to the content process channel. r=mayhemer,necko-reviewers

https://hg.mozilla.org/mozilla-central/rev/2800984d36d6

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(matt.woodrow)

== Change summary for alert #25680 (as of Wed, 22 Apr 2020 16:02:21 GMT) ==

Regressions:

101% raptor-tp6-twitter-firefox-cold loadtime macosx1014-64-shippable opt 1,235.92 -> 2,487.58
79% raptor-tp6-twitter-firefox-cold loadtime windows7-32-shippable opt 809.42 -> 1,450.17
72% raptor-tp6-twitter-firefox-cold loadtime linux64-shippable-qr opt 905.50 -> 1,559.67
72% raptor-tp6-twitter-firefox-cold loadtime windows10-64-shippable opt 846.42 -> 1,457.33
72% raptor-tp6-twitter-firefox-cold loadtime linux64-shippable opt 904.17 -> 1,552.25
66% raptor-tp6-twitter-firefox-cold loadtime windows10-64-shippable-qr opt 879.62 -> 1,463.75

Improvements:

33% raptor-tp6-pinterest-firefox-cold fcp windows10-64-shippable opt 857.92 -> 574.00
28% raptor-tp6-pinterest-firefox-cold fcp windows7-32-shippable opt 844.29 -> 604.00
27% raptor-tp6-pinterest-firefox-cold fcp linux64-shippable opt 863.17 -> 627.25
27% raptor-tp6-twitter-firefox-cold fcp linux64-shippable opt 808.83 -> 594.17
26% raptor-tp6-twitter-firefox-cold fcp linux64-shippable-qr opt 811.00 -> 597.42
26% raptor-tp6-pinterest-firefox-cold fcp windows10-64-shippable-qr opt 799.46 -> 593.17
25% raptor-tp6-pinterest-firefox-cold fcp linux64-shippable-qr opt 859.42 -> 644.50
24% raptor-tp6-twitter-firefox-cold fcp windows7-32-shippable opt 742.08 -> 566.58
23% raptor-tp6-twitter-firefox-cold fcp windows10-64-shippable-qr opt 711.33 -> 545.00
23% raptor-tp6-twitter-firefox-cold fcp windows10-64-shippable opt 731.92 -> 564.75
21% raptor-tp6-pinterest-firefox-cold linux64-shippable opt 1,130.97 -> 890.13
21% raptor-tp6-pinterest-firefox-cold linux64-shippable-qr opt 1,144.14 -> 906.65
20% raptor-tp6-pinterest-firefox-cold windows10-64-shippable opt 1,070.40 -> 856.51
19% raptor-tp6-pinterest-firefox-cold windows7-32-shippable opt 1,055.23 -> 854.66
18% raptor-tp6-pinterest-firefox-cold fcp macosx1014-64-shippable opt 1,322.00 -> 1,078.92
18% raptor-tp6-pinterest-firefox-cold windows10-64-shippable-qr opt 1,046.52 -> 856.28
18% raptor-tp6-twitter-firefox-cold fcp macosx1014-64-shippable opt 1,106.00 -> 909.75
14% raptor-tp6-pinterest-firefox-cold macosx1014-64-shippable opt 1,651.95 -> 1,415.97
10% raptor-tp6-office-firefox-cold fcp linux64-shippable-qr opt 506.92 -> 455.17
10% raptor-tp6-office-firefox-cold fcp linux64-shippable opt 503.67 -> 452.83
10% raptor-tp6-twitter-firefox-cold linux64-shippable opt 811.10 -> 732.19
10% raptor-tp6-twitter-firefox-cold linux64-shippable-qr opt 811.83 -> 733.86
9% raptor-tp6-facebook-firefox-cold fcp linux64-shippable opt 716.58 -> 652.92
8% raptor-tp6-pinterest-firefox-cold loadtime linux64-shippable opt 2,134.83 -> 1,955.92
8% raptor-tp6-facebook-firefox-cold fcp linux64-shippable-qr opt 715.79 -> 658.33
8% raptor-tp6-office-firefox-cold linux64-shippable opt 507.01 -> 466.44
8% raptor-tp6-microsoft-firefox-cold fcp linux64-shippable opt 526.58 -> 485.08
8% raptor-tp6-microsoft-firefox-cold linux64-shippable opt 587.21 -> 542.86
8% raptor-tp6-pinterest-firefox-cold loadtime windows10-64-shippable opt 1,975.75 -> 1,827.50
7% raptor-tp6-twitter-firefox-cold windows10-64-shippable-qr opt 731.52 -> 676.80
7% raptor-tp6-pinterest-firefox-cold loadtime linux64-shippable-qr opt 2,138.38 -> 1,978.92
7% raptor-tp6-pinterest-firefox-cold loadtime windows10-64-shippable-qr opt 1,975.88 -> 1,828.50
7% raptor-tp6-facebook-firefox-cold linux64-shippable opt 905.78 -> 838.98
7% raptor-tp6-microsoft-firefox-cold fcp windows10-64-shippable-qr opt 547.96 -> 507.67
7% raptor-tp6-twitter-firefox-cold windows7-32-shippable opt 733.65 -> 679.85
7% raptor-tp6-office-firefox-cold linux64-shippable-qr opt 504.52 -> 468.29
7% raptor-tp6-pinterest-firefox-cold loadtime windows7-32-shippable opt 1,941.67 -> 1,803.75
7% raptor-tp6-facebook-firefox-cold linux64-shippable-qr opt 906.06 -> 845.37
7% raptor-tp6-microsoft-firefox-cold fcp windows10-64-shippable opt 486.83 -> 454.42
7% raptor-tp6-twitter-firefox-cold windows10-64-shippable opt 725.27 -> 677.95
6% raptor-tp6-microsoft-firefox-cold fcp windows7-32-shippable opt 487.83 -> 456.67
6% raptor-tp6-microsoft-firefox-cold fcp linux64-shippable-qr opt 568.42 -> 532.17
6% raptor-tp6-microsoft-firefox-cold loadtime linux64-shippable opt 886.21 -> 831.33
6% raptor-tp6-facebook-old-firefox-cold fcp linux64-shippable opt 727.88 -> 683.50
6% raptor-tp6-microsoft-firefox-cold linux64-shippable-qr opt 586.20 -> 552.71
6% raptor-tp6-microsoft-firefox-cold windows10-64-shippable-qr opt 503.21 -> 474.63
5% raptor-tp6-facebook-firefox-cold fcp windows10-64-shippable opt 663.71 -> 627.58
5% raptor-tp6-facebook-old-firefox-cold linux64-shippable opt 974.73 -> 926.23
5% raptor-tp6-facebook-firefox-cold windows10-64-shippable opt 827.05 -> 786.41
5% raptor-tp6-facebook-firefox-cold fcp windows7-32-shippable opt 657.17 -> 625.92
5% raptor-tp6-microsoft-firefox-cold windows10-64-shippable opt 494.13 -> 471.52
4% raptor-tp6-netflix-firefox-cold fcp linux64-shippable opt 600.83 -> 575.00
4% raptor-tp6-microsoft-firefox-cold windows7-32-shippable opt 496.28 -> 475.16
4% raptor-tp6-facebook-firefox-cold windows7-32-shippable opt 818.03 -> 784.17
4% raptor-tp6-netflix-firefox-cold linux64-shippable opt 802.06 -> 771.94
3% raptor-tp6-netflix-firefox-cold windows10-64-shippable-qr opt 761.85 -> 738.76
3% raptor-tp6-slides-firefox-cold windows10-64-shippable-qr opt 1,304.46 -> 1,267.00
3% raptor-tp6-microsoft-firefox-cold loadtime linux64-shippable-qr opt 839.08 -> 815.25
3% raptor-tp6-netflix-firefox-cold fcp windows10-64-shippable-qr opt 591.04 -> 574.58
3% raptor-tp6-sheets-firefox-cold fcp linux64-shippable opt 788.38 -> 766.83
2% raptor-tp6-sheets-firefox-cold linux64-shippable opt 923.81 -> 902.99
2% raptor-tp6-facebook-firefox-cold loadtime linux64-shippable opt 1,948.83 -> 1,905.33
2% raptor-tp6-sheets-firefox-cold fcp linux64-shippable-qr opt 881.46 -> 861.83
2% raptor-tp6-sheets-firefox-cold linux64-shippable-qr opt 949.56 -> 930.56

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25680

Looks like the alerts are the proper inverse of the original improvements/regressions noted in #c0, so I think we're good?

Comment on attachment 9140906 [details]
Bug 1623849 - Stop DocumentLoadListener from copying INHIBIT_PERSISTENT_CACHING to the content process channel. r?mayhemer

Beta/Release Uplift Approval Request

  • User impact if declined: Load time regressions on some raptor pages
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just reverts the network load flags changes accidentally introduced by the regressing patch.
  • String changes made/needed: None
Flags: needinfo?(matt.woodrow)
Attachment #9140906 - Flags: approval-mozilla-beta?

Comment on attachment 9140906 [details]
Bug 1623849 - Stop DocumentLoadListener from copying INHIBIT_PERSISTENT_CACHING to the content process channel. r?mayhemer

Fixes a perf regression. Approved for 76.0b8.

Attachment #9140906 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: