Closed Bug 1623917 Opened 5 years ago Closed 5 years ago

Talos still not producing minidumps for shutdown hangs because it throws an error before dumping

Categories

(Testing :: Talos, defect, P1)

Product:
Testing
Component:
Talos
Version:
Version 3
Type:
defect

Tracking

(firefox76 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1623917 - actually call kill_and_get_minidump if talos shutdown times out, r?whimboo
47 bytes, text/x-phabricator-request
Details | Review

Originally the code was:

  1. log something
  2. minidump
  3. raise error

and then the review nit was that the error should have the same message as the log message. So I deleted the error raising and modified the logging to raise the error. Which was great, except now the minidumping never happens...

Priority: -- → P1
See Also: → 1623890
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/73ef85b13272 actually call kill_and_get_minidump if talos shutdown times out, r=whimboo,perftest-reviewers,sparky

https://hg.mozilla.org/mozilla-central/rev/73ef85b13272

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Blocks: 1623890
See Also: 1623890 →
Blocks: 1625888
Blocks: 1629005
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: