1623951 - Convert hash urls to standard urls in treeherder and perfherder IFV

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P1)

Description

[Cameron Dawson [:camd]]

The standard Treeherder URL is something like:

https://treeherder.mozilla.org/#/jobs?repo=autoland

Notice the # in there. It's a relic from our AngularJS days. But it makes using standard URL libraries harder. We have quite a bit of awkward URL handling code in our helpers to work around this.

We need to backward support and convert old urls to be more like:

https://treeherder.mozilla.org/jobs?repo=autoland

Perhaps while we're at it, we should change the term of jobs to tasks.

Some work like this is done in the models/filter.js file. We parse the string, then re-push it. Part of the issue is that we have special handling for the hash being there right now. We'd have to convert all that helper code. But maintain that first parse to handle the hash being either there or not there.

Comment 1

[Sarah Clements [:sclements]]

I'll do this as part of the prep work for bug 1643117.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6677

Comment 3

[Sarah Clements [:sclements]]

Merged: https://github.com/mozilla/treeherder/commit/f98bc47524ace9fc149f9ec3b767631b6af8769b

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6819

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6825