Closed Bug 1623957 Opened 5 years ago Closed 5 years ago

Replace mfbt/TypeTraits with <type_traits>

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla76

Tracking Flags:

Tracking

Status

firefox76

---

fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(17 files)

Bug 1623957 - Part 1: Replace mozilla::IsSame with std::is_same. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 2: Replace mozilla::Decay with std::decay. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 3: Replace mozilla::IsEmpty with std::is_empty. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 4: Replace mozilla::DeclVal with std::declval. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 5: Replace mozilla::RemovePointer with std::remove_pointer. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 6: Replace mozilla::IsConvertible with std::is_convertible. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 7: Replace mozilla::EnableIf with std::enable_if. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 8: Replace mozilla::IsUnsigned with std::is_unsigned. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 9: Replace mozilla::IsVoid with std::is_void. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 10: Replace mozilla::Conditional with std::conditional. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 11: Replace mozilla::IsEnum with std::is_enum. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 12: Replace mozilla::MakeUnsigned with std::make_unsigned. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 13: Replace mozilla::IsSigned with std::is_signed. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 14: Replace mozilla::IsPointer with std::is_pointer. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 15: Replace mozilla::RemoveReference with std::remove_reference. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 16: Replace mozilla::RemoveConst with std::remove_const. r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1623957 - Part 17: Remove stray includes for "mfbt/TypeTraits.h". r=jwalden! 5 years ago André Bargull [:anba] 47 bytes, text/x-phabricator-request		Details \| Review

André Bargull [:anba]

Assignee

Description

•

5 years ago

Similar to bug 1607826 and bug 1607796.

In the past there have been some issues when newer STL features were used, but it seems like all our supported compilers support all <type_traits> replacements for mfbt/TypeTraits.h.

André Bargull [:anba]

Assignee

Comment 1

•

5 years ago

Attached file Bug 1623957 - Part 1: Replace mozilla::IsSame with std::is_same. r=jwalden! — Details

André Bargull [:anba]

Assignee

Comment 2

•

5 years ago

Attached file Bug 1623957 - Part 2: Replace mozilla::Decay with std::decay. r=jwalden! — Details

Depends on D67648

André Bargull [:anba]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1623957 - Part 3: Replace mozilla::IsEmpty with std::is_empty. r=jwalden! — Details

Depends on D67649

André Bargull [:anba]

Assignee

Comment 4

•

5 years ago

Attached file Bug 1623957 - Part 4: Replace mozilla::DeclVal with std::declval. r=jwalden! — Details

Depends on D67650

André Bargull [:anba]

Assignee

Comment 5

•

5 years ago

Attached file Bug 1623957 - Part 5: Replace mozilla::RemovePointer with std::remove_pointer. r=jwalden! — Details

Depends on D67651

André Bargull [:anba]

Assignee

Comment 6

•

5 years ago

Attached file Bug 1623957 - Part 6: Replace mozilla::IsConvertible with std::is_convertible. r=jwalden! — Details

Depends on D67652

André Bargull [:anba]

Assignee

Comment 7

•

5 years ago

Attached file Bug 1623957 - Part 7: Replace mozilla::EnableIf with std::enable_if. r=jwalden! — Details

Depends on D67653

André Bargull [:anba]

Assignee

Comment 8

•

5 years ago

Attached file Bug 1623957 - Part 8: Replace mozilla::IsUnsigned with std::is_unsigned. r=jwalden! — Details

Depends on D67655

André Bargull [:anba]

Assignee

Comment 9

•

5 years ago

Attached file Bug 1623957 - Part 9: Replace mozilla::IsVoid with std::is_void. r=jwalden! — Details

Depends on D67656

André Bargull [:anba]

Assignee

Comment 10

•

5 years ago

Attached file Bug 1623957 - Part 10: Replace mozilla::Conditional with std::conditional. r=jwalden! — Details

Depends on D67657

André Bargull [:anba]

Assignee

Comment 11

•

5 years ago

Attached file Bug 1623957 - Part 11: Replace mozilla::IsEnum with std::is_enum. r=jwalden! — Details

Depends on D67658

André Bargull [:anba]

Assignee

Comment 12

•

5 years ago

Attached file Bug 1623957 - Part 12: Replace mozilla::MakeUnsigned with std::make_unsigned. r=jwalden! — Details

Depends on D67659

André Bargull [:anba]

Assignee

Comment 13

•

5 years ago

Attached file Bug 1623957 - Part 13: Replace mozilla::IsSigned with std::is_signed. r=jwalden! — Details

Depends on D67660

André Bargull [:anba]

Assignee

Comment 14

•

5 years ago

Attached file Bug 1623957 - Part 14: Replace mozilla::IsPointer with std::is_pointer. r=jwalden! — Details

Also reenable the static_assert which was disabled for some reason in
bug 1308236. (Bug 1308236 doesn't contain any information why this assertion
had to be disabled.)

Depends on D67661

André Bargull [:anba]

Assignee

Comment 15

•

5 years ago

Attached file Bug 1623957 - Part 15: Replace mozilla::RemoveReference with std::remove_reference. r=jwalden! — Details

Depends on D67662

André Bargull [:anba]

Assignee

Comment 16

•

5 years ago

Attached file Bug 1623957 - Part 16: Replace mozilla::RemoveConst with std::remove_const. r=jwalden! — Details

Depends on D67663

André Bargull [:anba]

Assignee

Comment 17

•

5 years ago

Attached file Bug 1623957 - Part 17: Remove stray includes for "mfbt/TypeTraits.h". r=jwalden! — Details

Depends on D67664

Pulsebot

Comment 18

•

5 years ago

Pushed by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d6d34d4374a7 Part 1: Replace mozilla::IsSame with std::is_same. r=jwalden https://hg.mozilla.org/integration/autoland/rev/eb49edf61849 Part 2: Replace mozilla::Decay with std::decay. r=jwalden https://hg.mozilla.org/integration/autoland/rev/477dab8b3324 Part 3: Replace mozilla::IsEmpty with std::is_empty. r=jwalden https://hg.mozilla.org/integration/autoland/rev/ee8e9c99d479 Part 4: Replace mozilla::DeclVal with std::declval. r=jwalden https://hg.mozilla.org/integration/autoland/rev/4e839607dda0 Part 5: Replace mozilla::RemovePointer with std::remove_pointer. r=jwalden https://hg.mozilla.org/integration/autoland/rev/680f4f1018e6 Part 6: Replace mozilla::IsConvertible with std::is_convertible. r=jwalden https://hg.mozilla.org/integration/autoland/rev/c6427d6143d9 Part 7: Replace mozilla::EnableIf with std::enable_if. r=jwalden https://hg.mozilla.org/integration/autoland/rev/2244abeb2f36 Part 8: Replace mozilla::IsUnsigned with std::is_unsigned. r=jwalden https://hg.mozilla.org/integration/autoland/rev/83191a5d4366 Part 9: Replace mozilla::IsVoid with std::is_void. r=jwalden https://hg.mozilla.org/integration/autoland/rev/49efd8881aab Part 10: Replace mozilla::Conditional with std::conditional. r=jwalden https://hg.mozilla.org/integration/autoland/rev/1079682d7967 Part 11: Replace mozilla::IsEnum with std::is_enum. r=jwalden https://hg.mozilla.org/integration/autoland/rev/2b72c54537e7 Part 12: Replace mozilla::MakeUnsigned with std::make_unsigned. r=jwalden https://hg.mozilla.org/integration/autoland/rev/4d6099637f6c Part 13: Replace mozilla::IsSigned with std::is_signed. r=jwalden https://hg.mozilla.org/integration/autoland/rev/5e7a6d158bc8 Part 14: Replace mozilla::IsPointer with std::is_pointer. r=jwalden https://hg.mozilla.org/integration/autoland/rev/150ae4897b76 Part 15: Replace mozilla::RemoveReference with std::remove_reference. r=jwalden https://hg.mozilla.org/integration/autoland/rev/8ac78029b636 Part 16: Replace mozilla::RemoveConst with std::remove_const. r=jwalden https://hg.mozilla.org/integration/autoland/rev/61a44ad12b15 Part 17: Remove stray includes for "mfbt/TypeTraits.h". r=jwalden

Arthur Iakab [arthur_iakab]

Comment 19

•

5 years ago

bugherder

Status: ASSIGNED → RESOLVED

Closed: 5 years ago

status-firefox76: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla76

You need to log in before you can comment on or make changes to this bug.