1623978 - Google homepage notification interrupts onboarding Search Tip

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Pablo]

Attachment: screenbug.png

Affected Versions
Nightly 76.0a1
Beta 75.0b6

Tested on:
Windows 10 x64 (affected)
Ubuntu 18.04 x64 (affected)
MacOS 10.14 (affected)

Steps to reproduce

• Launch Firefox (new profile)
• enable devtools.chrome.enabled in about config
• Hamburger menu> set options "restore previous session" checked
• Hamburger menu>set options "always check if firefox is your default browser" unchecked
• leave just one tab with a youtube video.
• web developer> browser console> enter this snippet and hit enter:
  (async function() { let { ProfileAge } = ChromeUtils.import("resource://gre/modules/ProfileAge.jsm"); let age = await ProfileAge(); age._times = { firstUse: 1368255600000, created: 1368255600000 }; await age.writeTimes(); })();
• close browser console.
• close firefox (only has a youtube tab)
• Reopen firefox
• type google.com in megabar

Actual Result:
There is an actual random result on the intervention. Sometimes it works but most of the time it does not. It shows for a micro second and dissapears completely.
There is also a blue notification showing in spanish (see screenshot). Even accepting the blue notification and repeating the process we get random results also, sometimes we repeat it without the blue bar at the top and intervention shows up, and most of the times intervention does not show up.

Expected result
Intervention should appear always.

Comment 1

[Harry Twyford]

Thanks for filing. The blue notification is part of the webpage. It's very unlikely that it has any impact on the behaviour of Search Tips. I'm also removing the word "result" from the bug title to avoid confusion with Urlbar results, which aren't really relevant to this report.

Are you creating a new profile every time you run this test? If not, what is the value of the pref browser.urlbar.tipShownCount.searchTip_onboard? If it is greater than or equal to 4, the Search Tip should not appear.

(In reply to Pablo from comment #0)

It shows for a micro second and disappears completely.

Could you please get a screen capture of this happening, if possible?

Comment 2

[Pablo]

Attachment: final.mp4

Comment 3

[Pablo]

Harry, i just uploaded a video,

please check several times at 1minute 29 seconds, the tip appears for a fraction of a second and dissapears.

its a clean firefox latest beta install. After the video if i go to about:Config... browser.urlbar.tipShownCount.searchTip_onboard is not found, but i do find a browser.urlbar.tipShownCount.searchTip_redirect = 1

Comment 4

[Pablo]

And that is very random,
I have seen it show the tip, not show the tip.

Sometimes if it does not show it... i close the browser with youtube and launch again, and go to google.com and still does not show it at second try.

And sometimes it shows the tip at 3rd try.

Comment 5

[Harry Twyford]

Thanks for the video – it's very helpful. Seeing how the blue notification loads in after the Search Tip makes me think my assumption here might have been wrong:

(In reply to Harry Twyford [:harry] from comment #1)

The blue notification is part of the webpage. It's very unlikely that it has any impact on the behaviour of Search Tips.

The notification might be triggering a new location change, which would hide the tip. We have a timeout on the Tip but it might not be adequate in this situation. This would probably be a P1, except judging by the text of the notification it'll probably go away on March 31. That's before Search Tips launch. It's still worth handling situations like this for the future so I'll mark this P2.

Comment 6

[Harry Twyford]

Attachment: Bug 1623978 - Disable Search Tips on secondary location changes. r?adw!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad77ecc62cdb
Disable Search Tips on secondary location changes. r=adw

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ad77ecc62cdb

Comment 9

[Pablo]

I tried to reproduce on Firefox latest nightly 76.0a1 and i can´t replicate the issue anymore.

Tested with:

Windows 10 64bit
Ubuntu 18.04 64bit
MacOS 10.14

it looks fixed on all 3 of them

Comment 10

[Pablo]

Issue is fixed