1623980 - Search interventions : Letters appear cut if window size is small

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P4)

Description

[Pablo]

Attachment: screenbug2.png

Affected Versions
Nightly 76.0a1
Beta 75.0b6

Tested on
Windows 10 x64 (affected)
Ubuntu 18.04 x64 (affected)
MacOS 10.14 (affected)

Steps to reproduce

-Launch Firefox
-Resize window to < 25%
-Type "update firefox"" in megabar (see screenshot, left side of refresh firefox button)

Actual Result:
intervention appears but some letters get cut

Expected result
letters should appear correctly

Comment 1

[Harry Twyford]

Attachment: Screen Shot 2020-03-20 at 2.50.12 PM.png

I'm surprised this is still happening. I thought we fixed this in bug 1600891 and I can't personally reproduce it (screenshot attached).

Are you resizing the window with the mouse or with the browser console? The fix for this was just a few CSS rules, so I don't think it should really matter, but that's all that comes to mind at the moment.

Comment 2

[Pablo]

hi harry, the resize im doing is with the mouse, bottom right corner of the screen. see screenshot attached
i get the result typing to make the intervention appear and then resizing,
or resizing the window first and then clicking on the megabar and typing.
file attached

Comment 3

[Pablo]

Attachment: sceen3.png

Comment 4

[Harry Twyford]

Looks like you're testing in Release. Could you please try the same test in Beta and Nightly? That said, this should be fixed in Release...

Comment 5

[Pablo]

that was beta, here is also nightly attached

Comment 6

[Pablo]

Attachment: nightlyscreen.png

Comment 7

[Pablo]

Attachment: betascreen.png

Comment 8

[Drew Willcoxon :adw]

I can reproduce this but only if the window height is also very small. I think this is worth fixing, and I'd like to know why the small window height affects the text flow because it seems like it shouldn't. But I also don't think it's a high priority.

Comment 9

[Harry Twyford]

Attachment: Bug 1623980 - Always wrap tip results at narrow window widths. r?dao

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 11

[Harry Twyford]

This isn't really a regression. This issue existed in the original implementation of tip results. It was fixed in some cases in bug 1600891 and this patch fixes it in all other cases.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/156272adf90c
Always wrap tip results at narrow window widths. r=dao

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/156272adf90c

Comment 14

[Daniel Cicas [:dcicas], Release QA]

Hello,

I can confirm that this issue is fixed on Fx 76.0b4 on Win 10 x64, mac OS 10.14 Ubuntu 18.04.