1624001 - Enable async shutdown logs for Marionette and Wdspec jobs in CI

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We have seen a lot of slow shutdowns of Firefox in CI in the last couple of months, which produce a fair amount of intermittent test failures. As such it would be good to get logging of those for improvements.

As noticed today there is the toolkit.asyncshutdown.log pref, which accepts a boolean value. Maybe we can turn it on when trace level logging is enabled. I wouldn't do it by default.

Maja, what do you think?

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Sounds fine to me. Do you have an example of what kind of logs this produces?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Maja Frydrychowicz :maja_zf (UTC-4) ([e-mail]) from comment #1)

Sounds fine to me. Do you have an example of what kind of logs this produces?

Not yet, but a try build might show us.

Gijs, given that you mentioned those logs on a different bug, is there any other preference we should also set when enabling those logs for Marionette?

Comment 3

[:Gijs (he/him)]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #2)

(In reply to Maja Frydrychowicz :maja_zf (UTC-4) ([e-mail]) from comment #1)

Sounds fine to me. Do you have an example of what kind of logs this produces?

Not yet, but a try build might show us.

Gijs, given that you mentioned those logs on a different bug, is there any other preference we should also set when enabling those logs for Marionette?

I don't think you need any other prefs, but I'm also not really sure what "trace level logging" is or when it is enabled.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to :Gijs (he/him) from comment #3)

Gijs, given that you mentioned those logs on a different bug, is there any other preference we should also set when enabling those logs for Marionette?

I don't think you need any other prefs, but I'm also not really sure what "trace level logging" is or when it is enabled.

That's a log level as used by Marionette for a more detailed log as debug already gives. Here a try push with the extension always set:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9fd0524f16e8c184c939ca9c8b2ff41f5f78711

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Asysn shutdown logs look like:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294353206&repo=try&lineNumber=43206

I think it's fine to enable those. Will have to check how to best do it for geckodriver.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1624001 - [marionette] Enable async shutdown log for Marionette and Wdspec tests in CI.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Note that I will enable the async shutdown logs only for CI by using --setpref=toolkit.asyncshutdown.log=true in the Taskcluster configuration of Mn and Wd jobs.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2c96c58335b
[marionette] Enable async shutdown log for Marionette and Wdspec tests in CI. r=tomprince

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b2c96c58335b

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please uplift this CI-only change to the mozilla-beta branch. Thanks.

Comment 11

[Andreea Pavel [:apavel]]

Henrik, we'll take care of it.

Julien, does this need to land directly on release? if so, does it need to land with DONTBUILD or without?

Comment 12

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/c4df6f5cb3e7