Closed Bug 1624001 Opened 5 months ago Closed 4 months ago

Enable async shutdown logs for Marionette and Wdspec jobs in CI

Categories

(Testing :: Marionette, task, P1)

Version 3
task

Tracking

(firefox-esr68 wontfix, firefox75 fixed, firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox-esr68 --- wontfix
firefox75 --- fixed
firefox76 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

We have seen a lot of slow shutdowns of Firefox in CI in the last couple of months, which produce a fair amount of intermittent test failures. As such it would be good to get logging of those for improvements.

As noticed today there is the toolkit.asyncshutdown.log pref, which accepts a boolean value. Maybe we can turn it on when trace level logging is enabled. I wouldn't do it by default.

Maja, what do you think?

Flags: needinfo?(mjzffr)

Sounds fine to me. Do you have an example of what kind of logs this produces?

Flags: needinfo?(mjzffr)

(In reply to Maja Frydrychowicz :maja_zf (UTC-4) (maja@mozilla.com) from comment #1)

Sounds fine to me. Do you have an example of what kind of logs this produces?

Not yet, but a try build might show us.

Gijs, given that you mentioned those logs on a different bug, is there any other preference we should also set when enabling those logs for Marionette?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #2)

(In reply to Maja Frydrychowicz :maja_zf (UTC-4) (maja@mozilla.com) from comment #1)

Sounds fine to me. Do you have an example of what kind of logs this produces?

Not yet, but a try build might show us.

Gijs, given that you mentioned those logs on a different bug, is there any other preference we should also set when enabling those logs for Marionette?

I don't think you need any other prefs, but I'm also not really sure what "trace level logging" is or when it is enabled.

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to :Gijs (he/him) from comment #3)

Gijs, given that you mentioned those logs on a different bug, is there any other preference we should also set when enabling those logs for Marionette?

I don't think you need any other prefs, but I'm also not really sure what "trace level logging" is or when it is enabled.

That's a log level as used by Marionette for a more detailed log as debug already gives. Here a try push with the extension always set:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9fd0524f16e8c184c939ca9c8b2ff41f5f78711

Asysn shutdown logs look like:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294353206&repo=try&lineNumber=43206

I think it's fine to enable those. Will have to check how to best do it for geckodriver.

Note that I will enable the async shutdown logs only for CI by using --setpref=toolkit.asyncshutdown.log=true in the Taskcluster configuration of Mn and Wd jobs.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P2 → P1
Summary: Enable async shutdown logs for Marionette and geckodriver with trace level logs enabled → Enable async shutdown logs for Marionette and Wdspec jobs in CI
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2c96c58335b
[marionette] Enable async shutdown log for Marionette and Wdspec tests in CI. r=tomprince
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76

Please uplift this CI-only change to the mozilla-beta branch. Thanks.

Flags: needinfo?(sheriffs)
Whiteboard: [checkin-needed-beta]

Henrik, we'll take care of it.

Julien, does this need to land directly on release? if so, does it need to land with DONTBUILD or without?

Flags: needinfo?(sheriffs) → needinfo?(jcristau)
Flags: needinfo?(jcristau)
You need to log in before you can comment on or make changes to this bug.