1624062 - Cannot register webRequest event from extension page in debug mode

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, defect)

Description

[Rob Wu [:robwu]]

I ran an extension in debug mode that relied on a webRequest listener in an extension page, and was surprised to see that the webRequest listener was not triggered in debug mode.

When I opened the global JavaScript console, I found the following errors:

can't access property "module", this.persistent is null ExtensionCommon.jsm:2195
can't access property "setUserInput", handler is undefined ExtensionParent.jsm:1186
can't access property "removeListener", handler is undefined ExtensionParent.jsm:1204
can't access property "removeListener", handler is undefined ExtensionParent.jsm:1204

The first error shows the source of my observed bugs. The this.persistent object is cleared before it is dereferenced: https://searchfox.org/mozilla-central/rev/f1f75f0a2d995241fbc454edfab4be1064c544e1/toolkit/components/extensions/ExtensionCommon.jsm#2187,2195

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1624062 - Support webRequest listeners from extension pages in debug mode

And remove an unused "ext"/"extension parameter from an existing test.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b61cb05fbfc9
Support webRequest listeners from extension pages in debug mode r=mixedpuppy

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/b61cb05fbfc9

Comment 4

[Julien Cristau [:jcristau]]

Comment on attachment 9134878 [details]
Bug 1624062 - Support webRequest listeners from extension pages in debug mode

let's get this on beta as well per https://bugzilla.mozilla.org/show_bug.cgi?id=1621935#c10

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8578b108a4be