1624080 - Simplify the implementation of HasAuthorSpecifiedRules.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1624080 - Simplify the implementation of HasAuthorSpecifiedRules. r=heycam

This patch computes the author-specified properties during the CSS cascade, and
removes the complex rule-tree-based implementation that tries to do the cascade
again.

This changes behavior in two ways, one of them which is not observable to
content, I believe:

• revert now re-enables the native styling. This was brought up in
  https://github.com/w3c/csswg-drafts/issues/4777 and I think it is a bug-fix.

  This is observable to content, and I'm adding a test for it.

• We don't look at inherited styles from our ancestors when inherit is
  specified in a non-author stylesheet. This was introduced for bug 452969 but
  we don't seem to inherit background anymore for file controls or such. It
  seems back then file controls used to have a text-field.

  I audited forms.css and ua.css and we don't explicitly inherit
  padding / border / background-color into any nested form control.

We keep the distinction between border/background and padding, because the later
has some callers. I think we should try to align with Chromium in the long run
and remove the padding bit.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac0d06c0ca93
Simplify the implementation of HasAuthorSpecifiedRules. r=heycam

Comment 3

[Razvan Maries]

Backed out for assertion failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C10%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-browser-chrome-e10s-1%2Cm%28bc1%29&revision=ac0d06c0ca9330d5356717094910e977cf8f6c29&selectedJob=294873391

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294873391&repo=autoland&lineNumber=37392

Backout: https://hg.mozilla.org/integration/autoland/rev/11a006e5dfc6a708ff73268186afae8361fb2949

Later edit: Another failure https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294879780&repo=autoland&lineNumber=2343

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33869dd6c775
Simplify the implementation of HasAuthorSpecifiedRules. r=heycam

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/33869dd6c775