Closed Bug 1624080 Opened 4 months ago Closed 3 months ago

Simplify the implementation of HasAuthorSpecifiedRules.

Categories

(Core :: CSS Parsing and Computation, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

No description provided.
Type: defect → task
Priority: -- → P3

This patch computes the author-specified properties during the CSS cascade, and
removes the complex rule-tree-based implementation that tries to do the cascade
again.

This changes behavior in two ways, one of them which is not observable to
content, I believe:

  • revert now re-enables the native styling. This was brought up in
    https://github.com/w3c/csswg-drafts/issues/4777 and I think it is a bug-fix.

    This is observable to content, and I'm adding a test for it.

  • We don't look at inherited styles from our ancestors when inherit is
    specified in a non-author stylesheet. This was introduced for bug 452969 but
    we don't seem to inherit background anymore for file controls or such. It
    seems back then file controls used to have a text-field.

    I audited forms.css and ua.css and we don't explicitly inherit
    padding / border / background-color into any nested form control.

We keep the distinction between border/background and padding, because the later
has some callers. I think we should try to align with Chromium in the long run
and remove the padding bit.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac0d06c0ca93
Simplify the implementation of HasAuthorSpecifiedRules. r=heycam
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33869dd6c775
Simplify the implementation of HasAuthorSpecifiedRules. r=heycam
Flags: needinfo?(emilio)
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.