162412 - Merge mi/mtext/ms into a single token class: nsMathMLTokenFrame

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[rbs]

Currently the class hierarchy looks like:

/* <mi> identifier - italics *sometimes*, i.e., context-sensitive */
nsMathMLmiFrame ------------+
                            |
/* <mtext> vanilla text */  |
nsMathMLmtextFrame ---------+--- nsMathMLContainerFrame --- nsHTMLContainerFrame
                            |
/* <ms> string which needs to be rendered with generated "quotes" */
nsMathMLmsFrame ------------+

The custom behaviors of each tag is handled by functions in these files. I would 
like to merge these files to cut the C++, and use the good old tag test to call 
the relevant functions. These are the MathML tags that have child nsTextFrames. 
Since text frames are non-MathML, they often require special handling. Merging 
will help to centralize the special handling. In particualar, the support of the 
|mathvariant| attribute needs special transformation in the text.

Bug 114365 comment 2 describes the full scope of the issues needed to support
this mathvariant attribute. This bug is a sub-task in the chain.

Comment 1

[rbs]

Attachment: proposed merge (no change of functionality)

Comment 2

[rbs]

Attachment: same without code that I had forgotten to remove after relocation

Comment 3

[rbs]

Attachment: iteration to clean those old .get() in the code being moved by the patch

Welcoming reviews at this stage.

Comment 4

[rbs]

bz/roc, care to review? It is essentially a shuffling of functions. Will be good 
to land this early in the milestone ot let it bake a bit.

Comment 5

[rbs]

bz said that he is about to catch a plane. 
pinging kin...

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 95142 [details] [diff] [review]
iteration to clean those old .get() in the code being moved by the patch

r=roc+moz

usual caveats apply...

Comment 7

[kinmoz]

Comment on attachment 95142 [details] [diff] [review]
iteration to clean those old .get() in the code being moved by the patch

sr=[e-mail]

I'm guessing mathml isn't built on Mac since there aren't any mac xml project
diffs, and no project xml files in the mathml dir?

Comment 8

[rbs]

oops, it is now built by default, after a loooong time... will take care of the
xml project stuff.

Comment 9

[rbs]

Attachment: update to sync with recent changes on the trunk and include macbuild diffs

Comment 10

[rbs]

Comment on attachment 95635 [details] [diff] [review]
update to sync with recent changes on the trunk and include macbuild diffs

migrating r/sr

Comment 11

[rbs]

Checked in.