1624146 - Refactor nsCookieService.cpp

Status: RESOLVED FIXED

(Core :: Networking: Cookies, task, P3)

Description

[Andrea Marchesini [:baku]]

This code is doing too much for a single file. Let's clean up the code.
The new configuration is:

• CookieStorage: a generic class to store cookies.
• CookiePrivateStorage: a CookieStorage implementation for private-browsing
• CookiePersistentStorage: a CookieStorage implementation for normal browsing
• CookieService: the previous nsCookieService
• CookieCommons: generic functions
• CookieLogging: logging methods.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 1 - Cookie, r?ehsan

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 2 - CookieKey, r?ehsan

Depends on D67749

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 3 - CookiePermission, r?ehsan

Depends on D67751

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 4 - DBState renamed CookieStorage, r?ehsan

Depends on D67752

Comment 5

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 5 - Separate files for CookieStorage, r?ehsan

Depends on D67753

Comment 6

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 6 - CookieStorage, r?ehsan

Depends on D67754

Comment 7

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 7 - CookiePrivateStorage and CookieDefaultStorage, r?ehsan

Depends on D67755

Comment 8

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 8 - CookieStorage observers pref changes, r?ehsan

Depends on D67756

Comment 9

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 9 - DB handling in CookieDefaultStorage, r?ehsan

Depends on D67757

Comment 10

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 10 - CookieService under mozilla::net, r?ehsan

Depends on D67758

Comment 11

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 11 - Separate files for CookiePrivateStorage and CookiePersistentStorage, r?ehsan

Depends on D67759

Comment 12

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 12 - Header cleanup, r?ehsan

Depends on D67760

Comment 13

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 13 - More functions in CookieCommons, r?ehsan

Depends on D67761

Comment 14

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 14 - Fix the namespaces, r?ehsan

Depends on D67762

Comment 15

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 15 - Remove mozIStorage* from CookieStorage, r?ehsan

Comment 16

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 16 - Separate files for the cookie parser, r?smaug

Depends on D67777

Comment 17

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 17 - Last methods in CookieCommons, r?smaug

Depends on D68078

Comment 18

[Olli Pettay [:smaug][[e-mail]]]

Btw, I think this should land after the next merge, which is next week.

Comment 19

[Andrea Marchesini [:baku]]

Attachment: Bug 1624146 - Cookie code refactoring - part 16 - Modernize c++ code, r?smaug

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc7a4f028bd4
Cookie code refactoring - part 1 - Cookie, r=smaug
https://hg.mozilla.org/integration/autoland/rev/ceaf03a667e8
Cookie code refactoring - part 2 - CookieKey, r=smaug
https://hg.mozilla.org/integration/autoland/rev/725ea3651ab1
Cookie code refactoring - part 3 - CookiePermission, r=smaug
https://hg.mozilla.org/integration/autoland/rev/650b38e09eff
Cookie code refactoring - part 4 - DBState renamed CookieStorage, r=smaug
https://hg.mozilla.org/integration/autoland/rev/c231dd605d08
Cookie code refactoring - part 5 - Separate files for CookieStorage, r=smaug
https://hg.mozilla.org/integration/autoland/rev/ef3152991931
Cookie code refactoring - part 6 - CookieStorage, r=smaug
https://hg.mozilla.org/integration/autoland/rev/4296c8aa8db3
Cookie code refactoring - part 7 - CookiePrivateStorage and CookieDefaultStorage, r=smaug
https://hg.mozilla.org/integration/autoland/rev/8f08ef21a89c
Cookie code refactoring - part 8 - CookieStorage observers pref changes, r=smaug
https://hg.mozilla.org/integration/autoland/rev/aa78111058f7
Cookie code refactoring - part 9 - DB handling in CookieDefaultStorage, r=smaug
https://hg.mozilla.org/integration/autoland/rev/8566c9426589
Cookie code refactoring - part 10 - CookieService under mozilla::net, r=smaug
https://hg.mozilla.org/integration/autoland/rev/3d356d8f5f01
Cookie code refactoring - part 11 - Separate files for CookiePrivateStorage and CookiePersistentStorage, r=smaug
https://hg.mozilla.org/integration/autoland/rev/ec78496d9606
Cookie code refactoring - part 12 - Header cleanup, r=smaug
https://hg.mozilla.org/integration/autoland/rev/406dfffcce59
Cookie code refactoring - part 13 - More functions in CookieCommons, r=smaug
https://hg.mozilla.org/integration/autoland/rev/f61489f19686
Cookie code refactoring - part 14 - Fix the namespaces, r=smaug
https://hg.mozilla.org/integration/autoland/rev/09afbdd67bd4
Cookie code refactoring - part 15 - Remove mozIStorage* from CookieStorage, r=smaug
https://hg.mozilla.org/integration/autoland/rev/13083ce12410
Cookie code refactoring - part 16 - Modernize c++ code, r=smaug

Comment 21

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/fc7a4f028bd4
https://hg.mozilla.org/mozilla-central/rev/ceaf03a667e8
https://hg.mozilla.org/mozilla-central/rev/725ea3651ab1
https://hg.mozilla.org/mozilla-central/rev/650b38e09eff
https://hg.mozilla.org/mozilla-central/rev/c231dd605d08
https://hg.mozilla.org/mozilla-central/rev/ef3152991931
https://hg.mozilla.org/mozilla-central/rev/4296c8aa8db3
https://hg.mozilla.org/mozilla-central/rev/8f08ef21a89c
https://hg.mozilla.org/mozilla-central/rev/aa78111058f7
https://hg.mozilla.org/mozilla-central/rev/8566c9426589
https://hg.mozilla.org/mozilla-central/rev/3d356d8f5f01
https://hg.mozilla.org/mozilla-central/rev/ec78496d9606
https://hg.mozilla.org/mozilla-central/rev/406dfffcce59
https://hg.mozilla.org/mozilla-central/rev/f61489f19686
https://hg.mozilla.org/mozilla-central/rev/09afbdd67bd4
https://hg.mozilla.org/mozilla-central/rev/13083ce12410