1624199 - regression: On KDE, Firefox restarts maximized, but changes into a small, then large, non-maximized window

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Darkspirit]

Attachment: 2020-03-22_16-06-38.mp4

KDE, X11, Debian Testing, Macbook Pro (WebRender qualified)

KDE Plasma: 5.17.5
KDE Framework: 5.62.0
Qt: 5.12.5
libgtk-3-0: 3.24.14-1
libgtk2.0-0: 2.24.32-4

STR: Open about:restartrequired, maximize window, restart.
Good: Firefox is maximized after restart.
Bad: Firefox is not maximized after restart.
mozregression --good 2020-03-10 --bad 2020-03-22 -a about:restartrequired

24:44.54 INFO: Last good revision: e34098b876a71642a351557eabb6f6ceae826336
24:44.54 INFO: First bad revision: 786ce3bfb9b5c1ee885564a01033320883dca760
24:44.54 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e34098b876a71642a351557eabb6f6ceae826336&tochange=786ce3bfb9b5c1ee885564a01033320883dca760

786ce3bfb9b5c1ee885564a01033320883dca760 Martin Stransky — Bug 1623106 [Linux/Gtk] Don't use window resize workaround for Gtk >= 3.24, r=jhorak

Comment 1

[Robert Mader [:rmader]]

Could you attach a Wayland debug log so we can see if it's the compositor or firefox? Something like WAYLAND_DEBUG=1 ./firefox > firefox.log 2>&1

Comment 2

[Darkspirit]

Bug 1623658 is a Wayland followup to bug 1623106.
But this regression is on KDE/X11. (Are they somewhat the same?)

Comment 3

[Martin Stránský [:stransky] (ni? me)]

BTW. can you test with KDE Plasma: 5.18?
Thanks.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

(In reply to Martin Stránský [:stransky] from comment #3)

BTW. can you test with KDE Plasma: 5.18?
Thanks.

Please test only if it's suitable for you, I perhaps also can find a box with KDE Plasma 5.18 somewhere.

Comment 5

[Darkspirit]

With last good/first bad revision this bug is not present with KDE/Wayland. It still works as expected.
GDK_BACKEND=wayland mozregression --launch 2020-03-22 -a about:restartrequired

Only X11 and XWayland seem to be affected.

Comment 6

[Darkspirit]

Will test with Ubuntu 20.04 which has Plasma 5.18.

Comment 7

[Darkspirit]

Same behavior and regression range with Plasma 5.18/X11 on Ubuntu 20.04.
First bad: mozregression --repo autoland --launch 786ce3bfb9b5c1ee885564a01033320883dca760 -a about:restartrequired
KDE Plasma: 5.18.3
KDE Framework: 5.67.0
Qt: 5.12.5
libgtk-3-0: 3.24.14-1ubuntu1
libgtk2.0-0: 2.24.32-4ubuntu4

Comment 8

[Darkspirit]

Same behavior and regression range with Plasma 5.18/X11 on Ubuntu 20.04.

It works as expected with Plasma 5.18/Wayland on Ubuntu 20.04. Like on Debian, only X11 and XWayland seem to be affected.
(sudo apt install plasma-workspace-wayland + reenable Wayland in /etc/gdm3/custom.conf)

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Okay, let's remove the workaround for Wayland only. I don't have time to investigate why it's still broken on X11.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1624199 [Linux/X11] Use resize workaround on X11 to avoid KDE regression, r?jhorak

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00f39328118b
[Linux/X11] Use resize workaround on X11 to avoid KDE regression, r=jhorak

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/00f39328118b