1624219 - Login autocomplete offered in page number field of pdf.js

Status: RESOLVED WORKSFORME

(Toolkit :: Password Manager, defect, P2)

Description

[mphokjele]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

I had a tab with a pdf file open. I clicked on the textbox to input a page number. Clicking the textbox, repeatedly causes the below action to occur repeatedly.

Actual results:

My saved logins were offered to me.

Expected results:

The input in the textbox should have been highlighted so I could either replace it with other text or append/prepend to it.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Matthew N. [:MattN]]

Can you share the URL of the PDF? What about a screenshot? Either way, please attach debug logs

Comment 3

[mphokjele]

(In reply to Matthew N. [:MattN] (PM me if request are blocking you) from comment #2)

Can you share the URL of the PDF? What about a screenshot? Either way, please attach debug logs

I couldn't take screenshots of my laptop since doing so makes the saved logins popup to clear. So I took a picture of my screen using my phone. I hope it is visible enough. https://send.firefox.com/download/6a4c147afcf3bdcb/#kp40tYGWbbtN6UyPjtx86A

Comment 4

[mphokjele]

(In reply to mphokjele from comment #3)

(In reply to Matthew N. [:MattN] (PM me if request are blocking you) from comment #2)

Can you share the URL of the PDF? What about a screenshot? Either way, please attach debug logs

I couldn't take screenshots of my laptop since doing so makes the saved logins popup to clear. So I took a picture of my screen using my phone. I hope it is visible enough. https://send.firefox.com/download/6a4c147afcf3bdcb/#kp40tYGWbbtN6UyPjtx86A

Debug logs: https://send.firefox.com/download/b029d1f78def9924/#OrclyZXnPu-lwtaatG2isg

I realised that the bug is only reproducible on remote pdfs which I view via my school's online portal, and it happens to have a saved login. Local files do not have this issue.

Comment 5

[Matthew N. [:MattN]]

I can reproduce this on https://bugs.mattn.ca/1040.pdf if I save a login for that site.

We had a previous issue with password manager on pdf.js. I wish the password field was only appended to the document when it was actually needed as it would reduce the frequency of this problem.

Comment 6

[Matthew N. [:MattN]]

Attachment: Debug logs

Comment 7

[Sergey Galich [:serg]]

I can not reproduce it on Firefox 97. Please reopen if you can reproduce it.