1624230 - nsProtocolProxyService.cpp: do not use 'else' after 'continue'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

        continue;
      } else if (token.Equals(mozilla::Tokenizer::Token::Char('/'))) {
        t.Claim(hostStr);
        t.Record();
        parsingMask = true;
        continue;
      } else if (token.Equals(mozilla::Tokenizer::Token::Char(']'))) {

do not use 'else' after 'continue'

https://searchfox.org/mozilla-central/source/netwerk/base/nsProtocolProxyService.cpp#1834-1843

As the change is pretty easy, it is mostly to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Liscare]

Attachment: Bug 1624230 - Replace else if with if after continue. r=andi

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40150e24e05f
Replace else if with if after continue. r=valentin

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/40150e24e05f