1624237 - Evaluate misc-unused-using-decls and potentially run it on the code base

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

http://clang.llvm.org/extra/clang-tidy/checks/misc-unused-using-decls.html

Seems that we have 200+ occurrences in the code base.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1624237 - Run misc-unused-using-decls - Remove useless declarations r?andi

$ ./mach static-analysis check --checks="-*, misc-unused-using-decls" --fix <path>

Comment 2

[Sylvestre Ledru [:Sylvestre]]

I am surprised by the only few number it fixed...
Should have been much bigger.
Maybe because/thanks to unified?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffbed74e25fd
Run misc-unused-using-decls - Remove useless declarations r=andi

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1624237 - Bring back using declaration - unified are broken

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d4295c1435b
Bring back using declaration - unified are broken. a=bustage-fix

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ffbed74e25fd
https://hg.mozilla.org/mozilla-central/rev/1d4295c1435b