1624377 - clang-cl: warning: unknown argument ignored in clang-cl '-msse4'; did you mean '-msse2'?

Status: RESOLVED FIXED

(NSS :: Build, task, P1)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

I'm getting this warning frequently on my local Windows build on MozillaBuild. I suspect failing to apply SSE might slower the whole build, is it the case?

98:29.72 security/nss/lib/pkcs7
98:30.02 In file included from c:/Users/Kagami/Documents/GitHub/gecko-dev/security/nss/lib/nss/nssinit.c:1324:
98:30.10 c:/Users/Kagami/Documents/GitHub/gecko-dev/obj-x86_64-pc-mingw32/dist/include/private/nss\verref.h(34,25): warning: unused variable '_nss_version_c' [-Wunused-v
ariable]
98:30.12     volatile const char _nss_version_c = NSS_VERSION_VARIABLE[0];
98:30.14                         ^
98:30.16 1 warning generated.
98:30.20 security/nss/lib/ckfw/builtins
98:32.29 In file included from c:/Users/Kagami/Documents/GitHub/gecko-dev/security/nss/lib/ckfw/builtins/binst.c:59:
98:32.34 c:/Users/Kagami/Documents/GitHub/gecko-dev/obj-x86_64-pc-mingw32/dist/include/private/nss\verref.h(34,25): warning: unused variable '_nss_version_c' [-Wunused-v
ariable]
98:32.39     volatile const char _nss_version_c = NSS_VERSION_VARIABLE[0];
98:32.46                         ^
98:32.54 1 warning generated.
98:32.61 clang-cl: warning: unknown argument ignored in clang-cl '-msse4'; did you mean '-msse2'? [-Wunknown-argument]
98:33.26 security/nss/lib/ssl
98:34.29 clang-cl: warning: unknown argument ignored in clang-cl '-msse4'; did you mean '-msse2'? [-Wunknown-argument]
98:34.87 security/nss/lib/dev
98:35.42 clang-cl: warning: unknown argument ignored in clang-cl '-msse4'; did you mean '-msse2'? [-Wunknown-argument]
98:36.44 security/nss/lib/ckfw/builtins/certdata.c.stub

Comment 1

[Nathan Froyd [:froydnj]]

This is an NSS build problem, not a Firefox one. (I think they should be using -msse4.2; perhaps the -msse4 is a new-ish alias?)

Comment 2

[J.C. Jones [:jcj] (he/they)]

Ben, please take on refactoring those -msse4 gyp flags in the next cycle.

Comment 3

[Benjamin Beurdouche [:beurdouche]]

Attachment: Bug 1624377 - Replace freebl flag -msse4 by -msse4.1 -msse4.2 which are supported by older compilers

Comment 4

[Kevin Jacobs [:kjacobs]]

https://hg.mozilla.org/projects/nss/rev/16ee7cb36fff9777c19939bf1f5c7145f7c7d1ca