1624396 - Centralized shader features list for WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Lee Salzman [:lsalzman]]

We have a number of use-cases of WebRender (such as SWGL, ANGLE shader validation, Jamie's shader optimization work) that need a list of shaders compiled into WebRender and also what feature keys have been enabled on those shaders. Currently all these cases are maintaining their own independent lists which can easily break any time shaders or features are modified in WebRender.

After discussion with Glenn, we have decided one of the easiest ways to approach this is to make a centralized list in webrender_build. After initial experiments with a purely data list, combinatoric explosion makes this list both hard to generate and hard to maintain. It seems like the best way to go here is just to programmatically generate the list in a way not unlike the shaders themselves are, which keeps the code to generate the list both small and manageable.

To ensure the list stays up to date, WebRender with check when instantiating new lazily-compiled shaders whether they are in this list, even if the shader is not used, just to strictly enforce the list and give developers immediate feedback if they forget to update it.

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1624396 - implement centralized shader features list management for WebRender. r?gw

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: Bug 1624396 - update SWGL to use the centralized WR shader list. r?jrmuizel

Depends on D67958

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: Bug 1624396 - add missing texture rectangle support to SWGL. r?jrmuizel

Depends on D67959

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1624396 - add necessary trigonometry intrinsics for conic gradients in SWGL. r?jrmuizel

Depends on D67960

Comment 5

[Lee Salzman [:lsalzman]]

Attachment: Bug 1624396 - update ANGLE shader validation tests to use centralized WR shader list. r?gw

Depends on D67961

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/178ba8ef059c
implement centralized shader features list management for WebRender. r=gw,jrmuizel,jnicol
https://hg.mozilla.org/integration/autoland/rev/72cbbe719b5d
update SWGL to use the centralized WR shader list. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/86954fd81261
add missing texture rectangle support to SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a6414fe1b3ec
add necessary trigonometry intrinsics for conic gradients in SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/86555508bdba
update ANGLE shader validation tests to use centralized WR shader list. r=gw

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/178ba8ef059c
https://hg.mozilla.org/mozilla-central/rev/72cbbe719b5d
https://hg.mozilla.org/mozilla-central/rev/86954fd81261
https://hg.mozilla.org/mozilla-central/rev/a6414fe1b3ec
https://hg.mozilla.org/mozilla-central/rev/86555508bdba