1624514 - Provide a convenient API to get a frame's logical content size

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

We have at least two use cases [1] [2] that use GetContentRectRelativeToSelf().Size() and then convert the physical size to logical size. We can provide an API for this.

[1] https://searchfox.org/mozilla-central/rev/202a285024f174c2d2bf2152d9cba90a03723eab/layout/base/RestyleManager.cpp#748
[2] https://searchfox.org/mozilla-central/rev/202a285024f174c2d2bf2152d9cba90a03723eab/layout/generic/nsFlexContainerFrame.cpp#4829-4830

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1624514 Part 1 - Move nsIFrame's methods that get various frame rects closer to GetRect(). r?dholbert

Let's make these methods more coherent and discoverable by moving them
closer to GetRect().

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1624514 Part 2 - Generalize nsIFrame::ContentBSize() to be ContentSize(). r?dholbert

To get the logical content size of a frame, some callers use
GetContentRectRelativeToSelf().Size() and then convert it to
LogicalRect. We really should generalize ContentBSize(), and provide
ContentSize() for such purpose.

Depends on D68064

Comment 3

[Daniel Holbert [:dholbert]]

These changes look sane to me (I gave them a quick skim and nothing jumped out at me).

Perhaps we could have AlaskanEmily pick these reviews up, though?

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Sure. I'll redirect the review to Emily.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4477b1bcc43
Part 1 - Move nsIFrame's methods that get various frame rects closer to GetRect(). r=AlaskanEmily
https://hg.mozilla.org/integration/autoland/rev/d2cd2c812a95
Part 2 - Generalize nsIFrame::ContentBSize() to be ContentSize(). r=AlaskanEmily

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d4477b1bcc43
https://hg.mozilla.org/mozilla-central/rev/d2cd2c812a95