1624627 - Revive the slow frame indicator

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

The indicator coming with the "gfx.webrender.debug.slow-frame-indicator" pref has been broken for a while. It was useful, though, let's revive it.

In addition it would be useful to add extra specific "slowness indicators", for example for scene building, frame building, rendering and whatever else we care about.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1624627 - Reimplement the slow frame indicator. r=jrmuizel

This removes the WebRender side of the previous slow frame indicator and replace it with a simple implementation that only looks at the CPU time on the render backend and renderer thread involved for building a frame.

A followup patch will add a separate indicator for when the displaylist/ipc/scene bits take too long.

Comment 2

[Nicolas Silva [:nical]]

Attachment: Bug 1624627 - Add a slow transaction indicator. r=jrmuizel

It moves when DL building + IPC + scene building takes more than 100ms.

Depends on D69247

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ca010d7a52d
Reimplement the slow frame indicator. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/af4366c6c434
Add a slow transaction indicator. r=jrmuizel

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3ca010d7a52d
https://hg.mozilla.org/mozilla-central/rev/af4366c6c434