1624633 - Factor methods operating on `Selection::mRanges` out

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Simplifies reasoning about them.

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1624633: part 1) Move `Selection::mRanges` to `StyledRanges` struct. r=hsivonen

This allows methods operating on the ranges to be moved to that struct.

To see where this leads to, consider the following reviews.

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1624633: part 2) Move `Selection::RemoveRangeInternal` to `StyledRanges::RemoveRangeAndUnregisterSelection`. r=hsivonen

Depends on D68217

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1624633: part 3) Move `FindInsertionPoint`. r=hsivonen

Depends on D68218

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1624633: part 4) Move `GetIndicesForInterval`. r=hsivonen

Depends on D68219

Comment 5

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1624633: part 5) Move `HasEqualRangeBoundariesAt`. r=hsivonen

Depends on D68220

Comment 6

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1624633: part 6) Annotate `nsRange::RegisterSelection` with `MOZ_CAN_RUN_SCRIPT`. r=hsivonen

Depends on D68221

Comment 7

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1624633: part 7) Move `MaybeAddRangeAndTruncateOverlaps`. r=hsivonen

Depends on D68222

Comment 8

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1624633: part 8) Move `GetCommonEditingHostForAllRanges`. r=hsivonen

Depends on D68223

Comment 9

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1624633: part 9) Move `FindRangeData`. r=hsivonen

Depends on D68224

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9add81beceb6
part 1) Move `Selection::mRanges` to `StyledRanges` struct. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/b4c0ff4a139a
part 2) Move `Selection::RemoveRangeInternal` to `StyledRanges::RemoveRangeAndUnregisterSelection`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/55795ecafd7d
part 3) Move `FindInsertionPoint`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/83a065358c0e
part 4) Move `GetIndicesForInterval`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/0df6851463dc
part 5) Move `HasEqualRangeBoundariesAt`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/4b365ca0c7fd
part 6) Annotate `nsRange::RegisterSelection` with `MOZ_CAN_RUN_SCRIPT`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/f569e40725db
part 7) Move `MaybeAddRangeAndTruncateOverlaps`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/02695524b550
part 8) Move `GetCommonEditingHostForAllRanges`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/cb0754b89f5e
part 9) Move `FindRangeData`. r=hsivonen

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9add81beceb6
https://hg.mozilla.org/mozilla-central/rev/b4c0ff4a139a
https://hg.mozilla.org/mozilla-central/rev/55795ecafd7d
https://hg.mozilla.org/mozilla-central/rev/83a065358c0e
https://hg.mozilla.org/mozilla-central/rev/0df6851463dc
https://hg.mozilla.org/mozilla-central/rev/4b365ca0c7fd
https://hg.mozilla.org/mozilla-central/rev/f569e40725db
https://hg.mozilla.org/mozilla-central/rev/02695524b550
https://hg.mozilla.org/mozilla-central/rev/cb0754b89f5e