1624646 - macOS OS re-auth string for credit card autofill has a redundant prefix provided by macOS

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P1)

Description

[Matthew N. [:MattN]]

“Firefox Nightly” is trying to Nightly is trying to use stored credit card information.

The macOS strings should have the %S is trying to prefix removed as that is provided by macOS already.

Comment 1

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

These are current, open bugs with a Severity of critical. The Severity of these bugs is being changed to S2 to be consistent with the May 4 2020 Severity definitions.

Please let Release Management know if these bugs are still S2.

Comment 3

[Matthew N. [:MattN]]

Jim, this isn't the same issue. There are two separate dialogs.

Comment 4

[Timea Cernea [:tbabos][inactive]]

Can confirm this issue affects the latest Nightly 79 (06/05/2020) on MacOS 10.13.

Comment 5

[Adam Roach [:abr]]

Attachment: Bug 1624646: Fix macOS re-auth strings r?mattn

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21ce615cc3c5
Fix macOS re-auth strings r=MattN

Comment 7

[Francesco Lodolo [:flod]]

This shouldn't have landed without comments on the strings.

Take for example the ones in about:logins
https://hg.mozilla.org/l10n/gecko-strings/file/default/browser/browser/aboutLogins.ftl#l113

# LOCALIZATION NOTE (editCreditCardPasswordPrompt.macos): This string is
# preceded by the operating system (macOS) with "Firefox is trying to ".
# Make sure to test in your locale.

Note: the comment needs to be repeated for each string.

@Adam
Can you fix this quickly? The alternative is that I ask for a backout, because I can't let these strings get out without a comment, and this will block me from exposing other strings.

Comment 8

[Adam Roach [:abr]]

Attachment: Bug 1624646: Adding localization notes for macos prompts r?flod

Comment 9

[Adam Roach [:abr]]

(In reply to Francesco Lodolo [:flod] from comment #7)

This shouldn't have landed without comments on the strings.

Take for example the ones in about:logins
https://hg.mozilla.org/l10n/gecko-strings/file/default/browser/browser/aboutLogins.ftl#l113

# LOCALIZATION NOTE (editCreditCardPasswordPrompt.macos): This string is
# preceded by the operating system (macOS) with "Firefox is trying to ".
# Make sure to test in your locale.

Note: the comment needs to be repeated for each string.

@Adam
Can you fix this quickly? The alternative is that I ask for a backout, because I can't let these strings get out without a comment, and this will block me from exposing other strings.

I'm not 100% sure I understand the request, but I've taken a stab at it in D78853. It's nearly 1:30 AM here, so I'll be asleep momentarily, but if you sign off (with or without comments), I'll put a patch into lando when I wake up.

Comment 10

[Francesco Lodolo [:flod]]

(In reply to Adam Roach [:abr] from comment #9)

I'm not 100% sure I understand the request, but I've taken a stab at it in D78853. It's nearly 1:30 AM here, so I'll be asleep momentarily, but if you sign off (with or without comments), I'll put a patch into lando when I wake up.

The approach in D78853 is correct, although I'm not sure it can land as is without rebases.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a9b28eb4698
Adding localization notes for macos prompts r=flod

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/21ce615cc3c5

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1a9b28eb4698

Comment 15

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on latest Nightly 79.0a1 (6-17-2020) on MacOS 10.13.