1624653 - Refactor getBoxQuads to calculate in layer pixels instead of css units

Status: NEW

(DevTools :: DOM, task, P3)

Description

[Brad Werth [:bradwerth]]

getBoxQuads and getBoxQuadsFromWindowOrigin both return values in CSS units, per spec. To do their work, they operate on layer pixels, then convert to CSS units at the end. Additionally, getBoxQuadsFromWindowOrigin is built on top of getBoxQuads, so it converts layer -> CSS -> layer -> CSS. This makes precision errors more likely and makes debugging more difficult. To ease this, we should refactor both functions to use a common function that does all the work in layer pixels (or possibly in app units). When that is done, then the additional work in getBoxQuadsFromWindowOrigin will manipulate only layer pixels and save two conversion steps.

Comment 1

[Ria Agnes Jose]

Hi, I would like to work on this bug. Could you please guide me where to begin?

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Hello Ria,
this bug isn't marked as good first bug and the complexity might be rather higher.
You can pick something less complex from this list:
https://codetribute.mozilla.org/projects/devtools