1624667 - ac_add_options --disable-tests disables the |mach jit-tests| command

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

If you have ac_add_options --disable-tests in a mozconfig with ac_add_options --enable-application=js then you can't use the command mach jit-test;

As near as I can tell this restriction isn't necessary, because I set enable-tests in mozconfig and re-ran the command and it worked with no rebuild.

Comment 1

[Mike Hommey [:glandium]]

The latter paragraph would be the actual issue.

Comment 2

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 3

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 4

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 5

[Firefox Bug Husbandry Bot]

The severity of these bugs was changed, mistakenly, from normal to S3.

Because these bugs have a priority of --, indicating that they have not been previously triaged, these bugs should be changed to Severity of --.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:rstewart, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 8

[Ricky Stewart]

Attachment: Bug 1624667 - Allow running `mach jit-test` if tests are disabled

This works fine, so no reason not to allow it.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:rstewart, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7d1953a8f0d
Allow running `mach jit-test` if tests are disabled r=mhentges,froydnj

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d7d1953a8f0d