1624681 - AudioBufferSourceNode.detune should not be clamped between -1200 and 1200

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P3)

Description

[tuomas]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

var source = audioCtx.createBufferSource();
source.detune.value = 1300;

Actual results:

The sound is detuned 1200 cents.

Expected results:

The sound should be detuned 1300 cents. This is consistent with the latest Web Audio API specification and the reported source.detune.minValue and source.detune.maxValue. Also this works as expected in Chrome.

This limit seems to be from an old specification: https://www.w3.org/TR/2015/WD-webaudio-20151208/#widl-AudioBufferSourceNode-detune

Clamping is done here: https://hg.mozilla.org/mozilla-central/file/be37fac7bc9e1498727048b131a42cbac8214011/dom/media/webaudio/AudioBufferSourceNode.cpp#l464

Comment 1

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 2

[Daniel Adams[:msub2]]

Attachment: Bug 1624681 - Remove clamp on AudioBufferSourceNode.detune. r=padenot

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/810271a1fed4
Remove clamp on AudioBufferSourceNode.detune. r=padenot

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/810271a1fed4