Closed Bug 1624763 Opened 5 years ago Closed 5 years ago

mach taskgraph action-callback does not call graph_config.register

Categories

(Firefox Build System :: Task Configuration, enhancement)

enhancement
Not set
normal

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(1 file)

I've successfully created and registered a simple generic action in comm/taskcluster/comm_taskgraph/actions.py using the graph_config.register() hook.

The decision task runs, the new action shows up in actions.json, and even in Treeherder under custom actions. When triggered though, the error says that the action is unknown.

That is happening because graph_config.register() doesn't get called when triggering an action callback.

The external taskgraph project calls the register hook at https://hg.mozilla.org/ci/taskgraph/file/f949fb56d96b9509b071ba55853f2d60e8dbbf57/src/taskgraph/actions/registry.py#l310.

See Also: → 1572316

This is a port of https://hg.mozilla.org/ci/taskgraph/rev/a61ab06c25222 to allow
for custom actions in a project repo. Previously, registration of actions worked
but did not run when triggered.

Assignee: nobody → rob
Status: NEW → ASSIGNED
Pushed by thunderbird@calypsoblue.org: https://hg.mozilla.org/integration/autoland/rev/3dce27394306 Enable custom actions to be defined in a repo. r=tomprince
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: