1624812 - Don't need to pass window while notifying content blocking events

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P1)

Description

[Dimi Lee [:dimi]]

After moving content blocking log to the parent process, we store the log in the top-level WindowGlobalParent. The process that finds the top-level WindowGlobalParent is done in the parent process.

This means we don't need to find the top-level window in child processes when notifying content blocking events anymore.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1624812 - P1. Don't need to pass a window when notifying content blocking events in child processes. r=timhuang

After moving content blocking log to the parent process, we store the
log in the top-level WindowGlobalParent. The process that finds the
top-level WindowGlobalParent is done in the parent process.

This means we don't need to find the top-level window in child
processes when notifying content blocking events anymore.

In this patch, we removing passing window in NotifyEventInChild, which
helps the next patch to remove code that gets top-level window while
notifying content blocking events in the child.

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1624812 - P2. Don't need to find the top-level window in ContentBlockingNotifier::OnDecision r=timhuang

We don't need to find the top-level window in the child because
the parent always do that while receiving content blocking events.

Depends on D68168

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/890232b93e92
P1. Don't need to pass a window when notifying content blocking events in child processes. r=timhuang,baku
https://hg.mozilla.org/integration/autoland/rev/6af7d890f86c
P2. Don't need to find the top-level window in ContentBlockingNotifier::OnDecision r=timhuang,baku

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/890232b93e92
https://hg.mozilla.org/mozilla-central/rev/6af7d890f86c

Comment 5

[Dimi Lee [:dimi]]

Attachment: Bug 1624812 - Fix accidentally removed line in previous commit. r=timhuang

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/448b302e2fe8
Fix accidentally removed line in previous commit. r=timhuang

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/448b302e2fe8