Closed Bug 1624946 Opened 5 years ago Closed 1 year ago

ShutDownKill signatures are overwhelming top crashers

Categories

(Socorro :: Webapp, defect, P2)

Product:
Socorro
Component:
Webapp
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: willkg, Unassigned)

Details

Previously, all the ShutDownKill crash reports were grouped together with the same signature and thus only took one slot in the Top Crashers reports.

Now, they're split out and take up a bunch of slots and it makes it seem like other signatures aren't interesting. Who cares about top crasher #38?

For example, Firefox 76.0a1 content top crashers:

https://crash-stats.mozilla.org/topcrashers/?product=Firefox&version=76.0a1&process_type=content

  1. IPCError-browser | ShutDownKill | mozilla::ipc::MessagePump::Run
  2. IPCError-browser | ShutDownKill | NtYieldExecution
  3. IPCError-browser | ShutDownKill | nsThread::Shutdown | mozilla::ChildProfilerController::ShutdownAndMaybeGrabShutdownProfileFirst
  4. IPCError-browser | ShutDownKill | hashglobe::hash_map::HashMap<T>::clear<T>
  5. IPCError-browser | ShutDownKill | EMPTY: no crashing thread identified; ERROR_NO_MINIDUMP_HEADER

This bug covers figuring out how to reduce ShutDownKill overwhelming the top crashers reports.

Making this a P2 since it's annoying.

Couple of options:

  1. undo what we did in bug #1612569 and reprocess everything
  2. filter out ShutDownKill crash reports and signatures from the top crashers lists altogether--they're not really crashes anyhow

Are there other options?

Priority: -- → P2

One other option would be to increase the time we give a content process to shut down. Right now it's 5 seconds, we could try to double it and see if the volume drops.

Changing the cutoff time would reduce the "shutdownkill reports overwhelm top crashers" problem over time, but wouldn't affect the existing crash reports or builds. I like that idea, but I think we need to do it in tandem with something else.

In bug #1667997, we added a report_type field and improved Top Crashers report to filter on the report type (all, crash, hang). That fixes this bug as well.

In bug #1844174, we will change the Top Crashers report to default to showing crashes-only. That reduces the steps to getting a no-hangs Top Crashers report.

I'm going to mark this FIXED.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.