1624954 - Support other aria-haspopup values besides "true"

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

STR:

1. Open https://a11ysupport.io/tests/html/aria/aria-haspopup_examples.html
2. Navigate to buttons

Result:
Only aria-haspopup=true is reported as a "menu button"

Expected:
The buttons with aria-haspopup should specify the type of popup

Comment 1

[Morgan Reschenberg [:morgan]]

We should also do state caching here if we can do it.

Comment 2

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1624954: query attribute string for aria-haspopup instead of relying on flag alone. r=eeejay

Comment 3

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1624954: Send state-change event when aria-haspopup value is changed to allow for caching. r=eeejay

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74085e028726
Send state-change event when aria-haspopup value is changed to allow for caching. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/2a3f592412a2
query attribute string for aria-haspopup instead of relying on flag alone. r=eeejay

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for linting failure on browser_aria_haspopup.js

backout: https://hg.mozilla.org/integration/autoland/rev/86285e58162d06746998e375c721e2a58e343e53

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2a3f592412a215e0b284c7d94bd7768cba0fd408&searchStr=Linting%2Copt%2CJavaScript%2Cchecks%2Csource-test-mozlint-eslint%2Cjs%28ES%29

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300282590&repo=autoland&lineNumber=111

[task 2020-04-30T20:30:27.388Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/accessible/tests/browser/mac/browser_aria_haspopup.js:14:22 | Parameter 'aState' uses Hungarian Notation, consider using 'state' instead. (mozilla/no-aArgs)
[task 2020-04-30T20:30:27.388Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/accessible/tests/browser/mac/browser_aria_haspopup.js:14:30 | Parameter 'aIsExtraState' uses Hungarian Notation, consider using 'isExtraState' instead. (mozilla/no-aArgs)
[task 2020-04-30T20:30:27.388Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/accessible/tests/browser/mac/browser_aria_haspopup.js:14:45 | Parameter 'aIsEnabled' uses Hungarian Notation, consider using 'isEnabled' instead. (mozilla/no-aArgs)
[task 2020-04-30T20:30:27.388Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/accessible/tests/browser/mac/browser_aria_haspopup.js:14:57 | Parameter 'aTarget' uses Hungarian Notation, consider using 'target' instead. (mozilla/no-aArgs)
[task 2020-04-30T20:30:27.388Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/accessible/tests/browser/mac/browser_aria_haspopup.js:33:3 | Parameter 'aID' uses Hungarian Notation, consider using 'iD' instead. (mozilla/no-aArgs)
[task 2020-04-30T20:30:27.388Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/accessible/tests/browser/mac/browser_aria_haspopup.js:34:3 | Parameter 'aARIAAttr' uses Hungarian Notation, consider using 'aRIAAttr' instead. (mozilla/no-aArgs)

Comment 6

[Natalia Csoregi [:nataliaCs]]

Also failing: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300287689&repo=autoland&lineNumber=1080

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91c7b2a3be82
Send state-change event when aria-haspopup value is changed to allow for caching. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/ab4e2bb58229
query attribute string for aria-haspopup instead of relying on flag alone. r=eeejay

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/91c7b2a3be82
https://hg.mozilla.org/mozilla-central/rev/ab4e2bb58229

Comment 9

[Eitan Isaacson [:eeejay]]

Morgan I tested this with VO and the STR above and I don't see this working. I suspect this has to do with the fact that we don't advertise AXHasPopup on buttons (because of the override in mozButtonAccessible.

Also, I think the actual value of aria-haspopup needs to go in AXPopupValue for this to work (and AXHasPopup needs to just be true or false).

Comment 10

[Eitan Isaacson [:eeejay]]

Until the STR above is fixed I think this needs to be reopened.

Comment 11

[Morgan Reschenberg [:morgan]]

(In reply to Eitan Isaacson [:eeejay] from comment #9)

Morgan I tested this with VO and the STR above and I don't see this working. I suspect this has to do with the fact that we don't advertise AXHasPopup on buttons (because of the override in mozButtonAccessible.

Also, I think the actual value of aria-haspopup needs to go in AXPopupValue for this to work (and AXHasPopup needs to just be true or false).

will do but
how did my test pass..? 🤕

Comment 12

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1624954: Add support for AXPopupValue, modify AXHasPopup to boolean. r=eeejay

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa760c9a719a
Add support for AXPopupValue, modify AXHasPopup to boolean. r=eeejay

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/aa760c9a719a

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:morgan, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 16

[Cristian Fogel [:cfogel]]

Confirmed issue with 77.0.1.
Fix verified with 78.0b7 on macOS 10.15.5.