Closed Bug 1624960 Opened 2 months ago Closed 2 months ago

Simplify some margin/padding values

Categories

(Toolkit :: Themes, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: ntim, Assigned: aji.yash13, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(2 files, 1 obsolete file)

Keywords: good-first-bug
Mentor: ntim.bugs

Hello Tim,
Can you give me some more information that need to be done ?

Flags: needinfo?(ntim.bugs)
Priority: -- → P3

(In reply to Ajitesh13 from comment #1)

Hello Tim,
Can you give me some more information that need to be done ?

Hey,

You should go through the comments at https://phabricator.services.mozilla.com/D67954#inline-404608 and apply them to the source code.

Most comments go this way:

{margin/padding}-inline-start: X;
{margin/padding}-inline-end: Y;

becomes

{margin/padding}-inline: X Y;

Similarly:

{margin/padding}-top: X;
{margin/padding}-bottom: Y;

becomes

{margin/padding}-block: X Y;

Please let me know if you have any questions :)

Flags: needinfo?(ntim.bugs)

Ok thanks, I will soon start working and let you know, if got some questions.

Do i also need to make the changes or just the comments?

Flags: needinfo?(ntim.bugs)

(In reply to Ajitesh13 from comment #4)

Do i also need to make the changes or just the comments?

You should make the changes described by the comments directly in the source code, make a patch and submit it :)

Flags: needinfo?(ntim.bugs)
Assignee: nobody → aji.yash13
Status: NEW → ASSIGNED
Attachment #9136463 - Attachment description: patch to Bug 1624960 r=ntim → Simplify some margin/padding values r=ntim
Attachment #9136463 - Attachment description: Simplify some margin/padding values r=ntim → Bug 1624960 - Simplify some margin/padding values r=ntim
Attachment #9136536 - Attachment is obsolete: true
Attachment #9136463 - Attachment description: Bug 1624960 - Simplify some margin/padding values r=ntim → Bug 1624960 - Simplify some margin/padding values. r=ntim
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ee66b2fb5734
Simplify some margin/padding values. r=ntim
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6be621426379
Followup: Remove unnecessary whitespace. DONTBUILD
Attachment #9136463 - Attachment description: Bug 1624960 - Simplify some margin/padding values. r=ntim → Bug 1624960 - Simplify some margin/padding values r=ntim
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.