1624960 - Simplify some margin/padding values

Status: RESOLVED FIXED

(Toolkit :: Themes, task, P3)

Description

[Tim Nguyen :ntim]

See review at https://phabricator.services.mozilla.com/D67954#2074294

Comment 1

[Ajitesh13]

Hello Tim,
Can you give me some more information that need to be done ?

Comment 2

[Tim Nguyen :ntim]

(In reply to Ajitesh13 from comment #1)

Hello Tim,
Can you give me some more information that need to be done ?

Hey,

You should go through the comments at https://phabricator.services.mozilla.com/D67954#inline-404608 and apply them to the source code.

Most comments go this way:

{margin/padding}-inline-start: X;
{margin/padding}-inline-end: Y;

becomes

{margin/padding}-inline: X Y;

Similarly:

{margin/padding}-top: X;
{margin/padding}-bottom: Y;

becomes

{margin/padding}-block: X Y;

Please let me know if you have any questions :)

Comment 3

[Ajitesh13]

Ok thanks, I will soon start working and let you know, if got some questions.

Comment 4

[Ajitesh13]

Do i also need to make the changes or just the comments?

Comment 5

[Tim Nguyen :ntim]

(In reply to Ajitesh13 from comment #4)

Do i also need to make the changes or just the comments?

You should make the changes described by the comments directly in the source code, make a patch and submit it :)

Comment 6

[Ajitesh13]

Attachment: Bug 1624960 - Simplify some margin/padding values r=ntim

Comment 7

[Ajitesh13]

Attachment: Bug 1624960 - Differential Revision: https://phabricator.services.mozilla.com/D68643 r=ntim

Depends on D68643

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee66b2fb5734
Simplify some margin/padding values. r=ntim

Comment 9

[Tim Nguyen :ntim]

Attachment: Bug 1624960 - Followup: Remove unnecessary whitespace. DONTBUILD

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6be621426379
Followup: Remove unnecessary whitespace. DONTBUILD

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ee66b2fb5734
https://hg.mozilla.org/mozilla-central/rev/6be621426379