1625028 - Add plain mochitest coverage for new-password heuristics

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P2)

Description

[Bianca Danforth [:bdanforth]]

Bug 1595244 changed the logic around when password generation is offered through the autocomplete popup for new password fields. While the patches there include a new unit test and updates to some existing tests (a unit test and some browser mochitests), we should also have coverage in plain mochitests.

One test that we may want to update for example is toolkit/components/passwordmgr/test/mochitest/test_autocomplete_new_password.html.

Comment 1

[Bianca Danforth [:bdanforth]]

Attachment: Bug 1625028 - Add plain mochitest coverage for new-password heuristics

WIP

Updated the toolkit/components/passwordmgr/test/mochitest/test_autocomplete_new_password.html test to include a third form that has enough signal for the new-password heuristics to detect its password field as a new password field. Factored out most of the test_autofillAutocompletePassword_withGeneration task to be re-checked for this new form. It's not pretty, and the telemetry accounting is very confusing (since autocomplete popup shown/used telemetry is per origin, the logins get cleared during the test, and the autocomplete popup performance telemetry is not per origin), but it's passing.

Comment 2

[Bianca Danforth [:bdanforth]]

Attachment: Bug 1625028 - Rename test_autocomplete_new_password.html to test_autocomplete_password_generation.html

Depends on D68499

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a829438cc04
Add plain mochitest coverage for new-password heuristics r=MattN

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79ccafa8b3c0
Rename test_autocomplete_new_password.html to test_autocomplete_password_generation.html r=MattN

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9a829438cc04

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/79ccafa8b3c0