1625030 - Wrench `perf` fixes and improvements

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Bert Peers [:bpeers]]

The perf command line option runs a benchmark but these would make it more useful for batch-run GPU performance analysis:

• it asserts with a drawcall mismatch; downgrade to a warning (this is normal when we cache things like gradients);
• GPU timing queries don't seem to work;
• the benchmark path is hardcoded; make it configurable;
• the number of frames to capture is hardcoded;
• an option to skip the first N frames could be useful (warmup peaks);
• support CSV output which is easier to digest across multiple runs;
• emit the min-max range of samples, not just the average;
• auto-generate output filename based on date+time;

Comment 1

[Bert Peers [:bpeers]]

Things I considered but decided against for now:

• fix the window position instead of letting windows DWM position wrench. This could help protect against wrench going partially off-screen or spilling over into a different-DPI monitor, potentially skewing results. However WindowBuilder doesn't have a with_position; the created window has a set_position but is inside a bunch of GL/angle plumbing that I'm not interested in right now :P
• saving more than just a single GPU number. Could be interesting to use the Tags to emit more queries, just not sure how best to approach that yet (declaring T : NamedTag and using timer.tag.get_label() in renderer.rs @941 works, just not sure what to do with that info. build a map and spit it all out into the CSV?)

Comment 2

[Bert Peers [:bpeers]]

Attachment: Bug 1625030 - Wrench `perf` fixes and improvements

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d91ed309433
Wrench `perf` fixes and improvements r=gw

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0d91ed309433