1625152 - `MOZ_CAN_RUN_SCRIPT` analysis warns for std::is_destructible on OSX

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Source Code Analysis, defect, P5)

Description

[André Bargull [:anba]]

Replacing mozilla::IsDestructible with std::is_destructible in xpcom/base/nsISupportsImpl.h results in the following errors on OSX:

[task 2020-03-25T18:39:52.026Z] 18:39:52    ERROR -  /builds/worker/fetches/clang/bin/../include/c++/v1/type_traits:2225:51: error: arguments must all be strong refs or caller's parameters when calling a function marked as MOZ_CAN_RUN_SCRIPT (including the implicit object argument).  '_VSTD::declval<_Tp1&>()' is neither.
[task 2020-03-25T18:39:52.026Z] 18:39:52     INFO -          typename __is_destructible_apply<decltype(_VSTD::declval<_Tp1&>().~_Tp1())>::type
[task 2020-03-25T18:39:52.026Z] 18:39:52     INFO -                                                    ^~~~~~~~~~~~~~~~~~~~~~~
[task 2020-03-25T18:39:52.026Z] 18:39:52     INFO -  /builds/worker/fetches/clang/bin/../include/c++/v1/__config:758:15: note: expanded from macro '_VSTD'
[task 2020-03-25T18:39:52.026Z] 18:39:52     INFO -  #define _VSTD std::_LIBCPP_ABI_NAMESPACE
[task 2020-03-25T18:39:52.026Z] 18:39:52     INFO -                ^

and

[task 2020-03-25T18:39:52.027Z] 18:39:52    ERROR -  /builds/worker/fetches/clang/bin/../include/c++/v1/type_traits:2225:51: error: functions marked as MOZ_CAN_RUN_SCRIPT can only be called from functions also marked as MOZ_CAN_RUN_SCRIPT
[task 2020-03-25T18:39:52.029Z] 18:39:52     INFO -          typename __is_destructible_apply<decltype(_VSTD::declval<_Tp1&>().~_Tp1())>::type
[task 2020-03-25T18:39:52.029Z] 18:39:52     INFO -                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2020-03-25T18:39:52.029Z] 18:39:52     INFO -  /builds/worker/fetches/clang/bin/../include/c++/v1/__config:758:15: note: expanded from macro '_VSTD'
[task 2020-03-25T18:39:52.029Z] 18:39:52     INFO -  #define _VSTD std::_LIBCPP_ABI_NAMESPACE
[task 2020-03-25T18:39:52.029Z] 18:39:52     INFO -                ^

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[(Away)]

That's really weird. Why are we running CanRunScriptChecker on the decltype(...) function being used within the standard library?

Comment 3

[Andi [:andi]]

Attachment: Bug 1625152 - relax MOZ_CAN_RUN_SCRIPT analysis for declval and decltype.

Comment 4

[Andi [:andi]]

This is no longer needed.