1625206 - Default Browser Agent's task still sending telemetry data with its pref set to false

Status: VERIFIED FIXED

(Toolkit :: General, defect, P1)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Affected versions

• Firefox 75.0b10 (treeherder build with Browser Agent implemented)
• Firefox 76.0a1

Affected platforms

• Windows 7 & 10

Steps to reproduce

1. Launch Firefox
2. Access about:config and set the following pref.: default-browser-agent.enabled to false
3. Search for Task scheduler and open it -> Extend Task Scheduler Library -> Select Mozilla folder
4. Select the Default Agent task and run it

Expected result

• The task will run and return with an error code

Actual result

• The task is successfully triggered, and telemetry is still sent

Regression range

• No regression as it was just implemented

Additional notes

• The sent data from the task can be seen in Fiddler

Comment 1

[Molly Howell (she/her) (mostly inactive)]

Found the problem. We're not reflecting pref values to the registry at all because of yet another place where I didn't carry over the build flag properly. Patch coming up.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1625206 - Correctly check the default agent build flag in xre. r=bytesized

Comment 3

[Molly Howell (she/her) (mostly inactive)]

I've checked in local builds that with this patch the flag does the right thing for the affected code when it is either enabled (the default) or disabled.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b32eaa3d954
Correctly check the default agent build flag in xre. r=bytesized

Comment 5

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 9136060 [details]
Bug 1625206 - Correctly check the default agent build flag in xre. r=bytesized

Beta/Release Uplift Approval Request

• User impact if declined: The default browser agent wouldn't honor the Firefox telemetry pref.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small targeted bug fix, and I've verified locally that the relevant build flag is now correctly honored when either enabled or disabled.
• String changes made/needed:

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5b32eaa3d954

Comment 7

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello ,

Confirming this issue as verified fixed .
Verified this issue on Nightly 76.0a1 (ID:20200327044807) (Treeherder build) with Win10x64.

Telemetry is not sent and the following message is displayed in Task Scheduler: "This program is blocked by group policy. For more information , please contact your system administrator (0X800704EC)"

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9136060 [details]
Bug 1625206 - Correctly check the default agent build flag in xre. r=bytesized

approved for 75rc1

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b9be436ea4fa

Comment 11

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Confirming this issue as verified fixed for 75.0b11(20200328010112). Telemetry is not sent.