Closed Bug 1625206 Opened 4 years ago Closed 4 years ago

Default Browser Agent's task still sending telemetry data with its pref set to false

Categories

(Toolkit :: General, defect, P1)

Desktop
Windows
defect

Tracking

()

VERIFIED FIXED
mozilla76
Tracking Status
firefox-esr68 --- unaffected
firefox74 --- unaffected
firefox75 + verified
firefox76 --- verified

People

(Reporter: csasca, Assigned: molly)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Affected versions

  • Firefox 75.0b10 (treeherder build with Browser Agent implemented)
  • Firefox 76.0a1

Affected platforms

  • Windows 7 & 10

Steps to reproduce

  1. Launch Firefox
  2. Access about:config and set the following pref.: default-browser-agent.enabled to false
  3. Search for Task scheduler and open it -> Extend Task Scheduler Library -> Select Mozilla folder
  4. Select the Default Agent task and run it

Expected result

  • The task will run and return with an error code

Actual result

  • The task is successfully triggered, and telemetry is still sent

Regression range

  • No regression as it was just implemented

Additional notes

  • The sent data from the task can be seen in Fiddler
Assignee: nobody → mhowell
Blocks: 1616497

Found the problem. We're not reflecting pref values to the registry at all because of yet another place where I didn't carry over the build flag properly. Patch coming up.

Status: NEW → ASSIGNED
Priority: -- → P1

I've checked in local builds that with this patch the flag does the right thing for the affected code when it is either enabled (the default) or disabled.

Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b32eaa3d954
Correctly check the default agent build flag in xre. r=bytesized

Comment on attachment 9136060 [details]
Bug 1625206 - Correctly check the default agent build flag in xre. r=bytesized

Beta/Release Uplift Approval Request

  • User impact if declined: The default browser agent wouldn't honor the Firefox telemetry pref.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a small targeted bug fix, and I've verified locally that the relevant build flag is now correctly honored when either enabled or disabled.
  • String changes made/needed:
Attachment #9136060 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
QA Whiteboard: [qa-triaged]

Hello ,

Confirming this issue as verified fixed .
Verified this issue on Nightly 76.0a1 (ID:20200327044807) (Treeherder build) with Win10x64.

Telemetry is not sent and the following message is displayed in Task Scheduler: "This program is blocked by group policy. For more information , please contact your system administrator (0X800704EC)"

Status: RESOLVED → VERIFIED

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

Comment on attachment 9136060 [details]
Bug 1625206 - Correctly check the default agent build flag in xre. r=bytesized

approved for 75rc1

Attachment #9136060 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Contact: catalin.sasca
Summary: Default Browser Agent's task still sending telemetry data with it's pref set to false → Default Browser Agent's task still sending telemetry data with its pref set to false

Hello,

Confirming this issue as verified fixed for 75.0b11(20200328010112). Telemetry is not sent.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: