1625209 - After reloading the page markupview keyboard shortcuts throw errors

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Julian Descottes [:jdescottes]]

What were you doing?

Please tell us what site you were on, and what steps led to the error you are reporting

1. Open the inspector
2. Reload the page
3. Use any keyboard shortcut in the markup view (eg, UP/DOWN etc...

What happened?

The following error is logged:

console.error: (new TypeError("can't access property \"createTreeWalker\", this.doc is null", "resource://devtools/client/inspector/markup/markup.js", 1017))
TypeError: can't access property "createTreeWalker", this.doc is null: _selectionWalker@resource://devtools/client/inspector/markup/markup.js:1017:20
Down@resource://devtools/client/inspector/markup/markup.js:176:33
_onShortcut@resource://devtools/client/inspector/markup/markup.js:1178:36
_initShortcuts/</<@resource://devtools/client/inspector/markup/markup.js:1165:39
_emit@resource://devtools/shared/event-emitter.js:226:34
emit@resource://devtools/shared/event-emitter.js:172:18
emit@resource://devtools/shared/event-emitter.js:324:18
handleEvent@resource://devtools/client/shared/key-shortcuts.js:282:27

What should have happened?

No error should be logged

Anything else we should know?

The errors come from the previous MarkupView instance. For each navigation/reload, the markup view is destroyed and recreated. When destroying the MarkupView, its Shortcuts object should also be destroyed.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1625209 - Remove keyboard shortcuts when destroying the DevTools MarkupView

Comment 2

[Julian Descottes [:jdescottes]]

Spotted while working on Bug 1611096.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0248631210d2
Remove keyboard shortcuts when destroying the DevTools MarkupView r=rcaliman

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0248631210d2