Closed Bug 1625217 Opened 5 years ago Closed 5 years ago

Minor issues with TestCrashHandler cleanup

Categories

(GeckoView :: General, defect, P1)

Unspecified
All
defect

Tracking

(firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

Details

(Whiteboard: [geckoview:m76])

Attachments

(1 file)

Essentially applying my learnings about service binding to TestCrashHandler.

ServiceConnection.onServiceDisconnected is not called if
Context.unbindService finished cleanly. We should be clearing mService in
that case.

Furthermore, if the service did die unexpectedly and
ServiceConnection.onServiceDisconnected was called, we need to explicitly
unbind so that Android does not automatically reconnect the binding.

Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5afc157c3755 Minor bug fixes to TestCrashHandler service binding; r=geckoview-reviewers,agi
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: