1625237 - Implement |tabs.toggleReaderMode|

Status: REOPENED

(GeckoView :: Extensions, enhancement, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

This can just be added to the TabDelegate as onToggleReaderMode.

Feel free to ask questions here or on https://chat.mozilla.org/#/room/#geckoview:mozilla.org if you want to work on this.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

This would be very similar to the implementation of tabs.remove, tracing that implementation is very helpful.

• Add a onToggleReaderMode to SessionTabDelegate here
• Add a toggleReaderMode method to GeckoViewTabBridge that sends a GeckoView:WebExtension:ToggleReaderMode message, similar to :CloseMessage here
• Add a async toggleReaderMode method to ext-tabs that calls GeckoViewTabBridge.toggleReaderMode here
• Handle GeckoView:WebExtension:ToggleReaderMode here. Basically just do this (without the legacyDelegate part).
• Add toggleReaderMode to the tabs schema here, copy it from the desktop implementation
• Add a test here that verifies that calling tabs.toggleReaderMode calls SessionTabDelegate.onToggleReaderMode, this is a good example to follow (just replace tabs.remove with tabs.toggleReaderMode and onCloseTab with onToggleReaderMode)

Comment 2

[Philippe]

Thanks for the details, I'll start looking the issue this weekend :)

Comment 3

[chocos]

I'll be looking into this issue.

Comment 4

[chocos]

Attachment: Bug 1625237 - Implement toggleReaderMode in FireFox Mobile. r?agi

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

chocos, are you still planning to work on this?

Comment 7

[james]

Hey,
What is the status of this bug?
I am new to contributing on mozilla code base, this is marked as good first bug so I hopped in here, if possible I wanna work on this but I have zero idea as to how to work on this and how to get started, it would be helpful if you provide me with some guidance.
Thank you

Comment 8

[[ex-Mozilla] Agi Sferro | :agi]

(In reply to james from comment #7)

Hey,
What is the status of this bug?
I am new to contributing on mozilla code base, this is marked as good first bug so I hopped in here, if possible I wanna work on this but I have zero idea as to how to work on this and how to get started, it would be helpful if you provide me with some guidance.
Thank you

Hi James! Comment 1 has a rough outline of what it would take to fix this bug, could you expand on what is not clear?

Comment 9

[james]

(In reply to Agi Sferro | :agi | ni? for questions | ⏰ PST | he/him from comment #8)

(In reply to james from comment #7)

Hey,
What is the status of this bug?
I am new to contributing on mozilla code base, this is marked as good first bug so I hopped in here, if possible I wanna work on this but I have zero idea as to how to work on this and how to get started, it would be helpful if you provide me with some guidance.
Thank you

Hi James! Comment 1 has a rough outline of what it would take to fix this bug, could you expand on what is not clear?

Hi,
I went trough Comment 1
I have a couple of questions,

1. What is onToogleReaderMode , How do I add it to the function and what exactly is the SessionTabDelegate function doing?
2. I don't really have an idea as to how to write a toogleReaderMode method that sends a GeckoView:WebExtension:ToggleReaderMode message
3. How do I write an async toggleReaderMode method to ext-tabs?
   It would be quite helpful if you could provide me with some documentation or explanations as I am quite new to all this, Thank you for your patience.

Comment 10

[Chris Peterson [:cpeterson]]

Tasks and enhancements should have severity N/A.

Comment 11

[Gabriel Luong [:gl] (ΦωΦ)]

Resolving as WONTFIX given that our intention is to move Reader Mode out of a WebExtension and built-in into GV.

Comment 12

[Rob Wu [:robwu]]

The tabs.toggleReaderMode extension API method would enable third party extensions to toggle the reader mode of a tab. The actual underlying implementation of Reader Mode is not relevant. I am therefore re-opening this bug.