1625288 - Broke camera unmute in WebRTC call on macOS

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

STR:

1. Open https://jsfiddle.net/jib1/z0desL8x/89/show/ and share camera
2. Click transceiver = pc.addTransceiver(trackA, {streams}) button
3. Click transceiver.sender.track.enabled = false button
4. Click transceiver.sender.track.enabled = true button

Expected result:

• Camera video appeared in 2, went black in 3, and reappeared in 3.

Actual result:

• Camera video appeared in 2, went black in 3, and remained black in 3.

Once the video disappears, there appears to be no way to get it back other than to refresh the page.

Regression range:
42:48.74 INFO: Narrowed inbound regression window from [25454b62, 0bf2c6b5] (4 builds) to [dc307d95, 0bf2c6b5] (2 builds) (~1 steps left)
42:48.74 INFO: No more inbound revisions, bisection finished.
42:48.74 INFO: Last good revision: dc307d95ba3591be70134cc4563cb9d0b0247bb1
42:48.74 INFO: First bad revision: 0bf2c6b5eed6f1314ff10b1a482b31c83af0cb85
42:48.74 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dc307d95ba3591be70134cc4563cb9d0b0247bb1&tochange=0bf2c6b5eed6f1314ff10b1a482b31c83af0cb85

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

[Tracking Requested - why for this release]: Web conference video may not recover from user muting & unmuting camera on mac.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I got confused by bug 1621500 not being closed. I saw the version number 74 and assumed it landed in 74. Luckily it is much more recent. Phew!

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Local mute/unmute works fine https://jsfiddle.net/jib1/3ykab1e2/39/show fyi, so this is something to do with RTCPeerConnection as a sink.

Update: I spoke too soon (forgot to move my head). Local video appears frozen while remote video is black, like comment 4

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I've confirmed this breaks camera unmute on https://whereby.com/ - Interestingly, it also freezes self-view there.

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1625288 - Fix broken camera unmute in WebRTC call on macOS; r=jib!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8388a059984
Fix broken camera unmute in WebRTC call on macOS; r=jib

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f8388a059984

Comment 8

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly build from 2020-03-26, verified that using latest Beta build 76.0b6 on macOS 10.15.5, this issue is no longer reproducible.