Request blocking "add" button is invisible
Categories
(DevTools :: Netmonitor, defect, P3)
Tracking
(firefox-esr68 unaffected, firefox75 wontfix, firefox76 wontfix, firefox77 fixed)
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox75 | --- | wontfix |
firefox76 | --- | wontfix |
firefox77 | --- | fixed |
People
(Reporter: fvsch, Assigned: lelouch.cpp, Mentored)
References
(Regression)
Details
(Keywords: good-first-bug, regression)
Attachments
(1 file)
It looks like the .request-blocking-enable-bar
container doesn't have display: flex
. So it has:
- a fixed height and overflow:hidden
- a first row with the text input
- a second row with the 'add' button
Might be a regression from:
https://hg.mozilla.org/mozilla-central/rev/2f2781fe9777260141c08e1e63be8b124d1d738f#l1.41
Updated•4 years ago
|
Reporter | ||
Comment 1•4 years ago
|
||
Honza, It looks like the "+" button has been invisible for a couple months. Today is the first time I've seen a user report for this (in Slack), from a contributor who saw a screenshot with the "+" button in a different bug.
This raises the question:
- Should we fix the regression and make the "+" button visible again?
- Or should we just remove the "+" button since the text input it focuses should always be visible, and users don't seem to miss it?
I'm fine with both.
For the Debugger we've been talking about removing the "+" buttons in SecondaryPanes accordion headers, but I'm not 100% sure we're going to do it.
This should probably block Bug 1588076 which deals with adding button to clear all the blocked URL/patterns
Comment 3•4 years ago
|
||
Ah, thanks for the report Florens, good catch!
(In reply to Florens Verschelde :fvsch from comment #1)
- Or should we just remove the "+" button since the text input it focuses should always be visible, and users don't seem to miss it?
I didn't even notice that it's missing and I agree that we don't need it.
Harald?
(In reply to Kriyszig from comment #2)
This should probably block Bug 1588076 which deals with adding button to clear all the blocked URL/patterns
Good point.
Honza
Updated•4 years ago
|
Updated•4 years ago
|
Comment 4•4 years ago
|
||
I didn't even notice that it's missing and I agree that we don't need it.
Agreed.
Can I take a shot at this issue in case no one is working on it currently?
Comment 6•4 years ago
|
||
Thank you Kriyszig, you are assigned!
Updated•4 years ago
|
The request-blocking-enable-bar
has no display: flex
and a
fixed height with overflow hidden. As a result of this, the add
button that shoulf have been placed next to the enable option
was pushed down out of view.
As a result, the add button was hidden for quite some time.
Based on the discussion in the bug report, it was decided to
remove the button altogether because a simple enter does the job
and user didn't seem to notice it missing thus proving it didn't
hinder the user experience.`
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/388c39350dca Remove the invisible add button in network blocking panel's top enable bar r=Honza
Comment 9•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Description
•