Closed Bug 1625406 Opened 4 years ago Closed 4 years ago

Request blocking "add" button is invisible

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(firefox-esr68 unaffected, firefox75 wontfix, firefox76 wontfix, firefox77 fixed)

RESOLVED FIXED
Firefox 77
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- wontfix
firefox76 --- wontfix
firefox77 --- fixed

People

(Reporter: fvsch, Assigned: lelouch.cpp, Mentored)

References

(Regression)

Details

(Keywords: good-first-bug, regression)

Attachments

(1 file)

It looks like the .request-blocking-enable-bar container doesn't have display: flex. So it has:

  • a fixed height and overflow:hidden
  • a first row with the text input
  • a second row with the 'add' button

Might be a regression from:
https://hg.mozilla.org/mozilla-central/rev/2f2781fe9777260141c08e1e63be8b124d1d738f#l1.41

Regressed by: 1590348
Has Regression Range: --- → yes

Honza, It looks like the "+" button has been invisible for a couple months. Today is the first time I've seen a user report for this (in Slack), from a contributor who saw a screenshot with the "+" button in a different bug.

This raises the question:

  • Should we fix the regression and make the "+" button visible again?
  • Or should we just remove the "+" button since the text input it focuses should always be visible, and users don't seem to miss it?

I'm fine with both.

For the Debugger we've been talking about removing the "+" buttons in SecondaryPanes accordion headers, but I'm not 100% sure we're going to do it.

Flags: needinfo?(odvarko)

This should probably block Bug 1588076 which deals with adding button to clear all the blocked URL/patterns

Ah, thanks for the report Florens, good catch!

(In reply to Florens Verschelde :fvsch from comment #1)

  • Or should we just remove the "+" button since the text input it focuses should always be visible, and users don't seem to miss it?

I didn't even notice that it's missing and I agree that we don't need it.
Harald?

(In reply to Kriyszig from comment #2)

This should probably block Bug 1588076 which deals with adding button to clear all the blocked URL/patterns

Good point.

Honza

Blocks: 1588076
Flags: needinfo?(odvarko) → needinfo?(hkirschner)

I didn't even notice that it's missing and I agree that we don't need it.

Agreed.

Flags: needinfo?(hkirschner)

Can I take a shot at this issue in case no one is working on it currently?

Thank you Kriyszig, you are assigned!

Assignee: nobody → lelouch.cpp
Status: NEW → ASSIGNED
Keywords: good-first-bug
Mentor: dwalsh

The request-blocking-enable-bar has no display: flex and a
fixed height with overflow hidden. As a result of this, the add
button that shoulf have been placed next to the enable option
was pushed down out of view.
As a result, the add button was hidden for quite some time.
Based on the discussion in the bug report, it was decided to
remove the button altogether because a simple enter does the job
and user didn't seem to notice it missing thus proving it didn't
hinder the user experience.`

Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/388c39350dca
Remove the invisible add button in network blocking panel's top enable bar r=Honza
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: