1625409 - Perma build messages "Traceback (most recent call last):" from toolkit/components/telemetry/build_scripts/mozparsers/shared_telemetry_utils.py

Status: RESOLVED FIXED

(WebExtensions :: Storage, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Build tasks are successful but contain the following error messages now:

https://treeherder.mozilla.org/logviewer.html#?job_id=294872171&repo=autoland

[task 2020-03-26T13:53:48.658Z] 13:53:48 INFO - The following entries are orphaned and should be removed from histogram-allowlists.json:
[task 2020-03-26T13:53:48.658Z] 13:53:48 INFO - STORAGE_SYNC_REMOVE_OPS
[task 2020-03-26T13:53:48.659Z] 13:53:48 INFO - Some errors occurred
[task 2020-03-26T13:53:48.659Z] 13:53:48 INFO - Error in atexit._run_exitfuncs:
[task 2020-03-26T13:53:48.659Z] 13:53:48 ERROR - Traceback (most recent call last):
[task 2020-03-26T13:53:48.659Z] 13:53:48 INFO - File "/builds/worker/checkouts/gecko/toolkit/components/telemetry/build_scripts/mozparsers/shared_telemetry_utils.py", line 98, in exit_func
[task 2020-03-26T13:53:48.659Z] 13:53:48 INFO - cls("Some errors occurred").handle_now()
[task 2020-03-26T13:53:48.659Z] 13:53:48 INFO - File "/builds/worker/checkouts/gecko/toolkit/components/telemetry/build_scripts/mozparsers/shared_telemetry_utils.py", line 88, in handle_now
[task 2020-03-26T13:53:48.659Z] 13:53:48 INFO - sys.exit(1)
[task 2020-03-26T13:53:48.659Z] 13:53:48 INFO - SystemExit: 1

This is from bug 1621742

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Thanks for spotting this :aryx
Unfortunately I did not notice the error when I build locally and when I pushed the patch to try (not that surprising given that, as you pointed out, the build task doesn't fail), and we didn't notice during the review on D67197 neither :-(

It looks like we just need to remote STORAGE_SYNC_REMOTE_OPS from that JSON file (which I wasn't aware of).
I'm on it.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1625409 - Remove STORAGE_SYNC_REMOVE_OPS from histogram-allowlist.json. r?janerik!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc4108cb49a6
Remove STORAGE_SYNC_REMOVE_OPS from histogram-allowlist.json. r=janerik

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/dc4108cb49a6