1625471 - Add a separate JSOp for CheckGlobalOrEvalDeclarationConflicts

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Jan de Mooij [:jandem]]

We call js::CheckGlobalOrEvalDeclarationConflicts in the prologue of global/eval scripts, but especially in IonBuilder this is pretty messy and also complicates bailouts. Adding a separate JSOp::CheckGlobalOrEvalDecl for this lets us clean this up.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1625471 - Add a separate JSOp for CheckGlobalOrEvalDeclarationConflicts. r?tcampbell!

Adds JSOp::CheckGlobalOrEvalDecl instead of calling CheckGlobalOrEvalDeclarationConflicts
in the prologue of global/eval scripts. This simplifies code in Baseline, IonBuilder
and Ion bailouts.

The new op is also implemented in WarpBuilder. This fixes a number of test failures
because it didn't handle this yet.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6daf3c4a812
Add a separate JSOp for CheckGlobalOrEvalDeclarationConflicts. r=tcampbell

Comment 3

[Jan de Mooij [:jandem]]

SmooshMonkey probably needs to emit JSOp::CheckGlobalOrEvalDecl in global and sloppy eval scripts before JSOp::Def* ops.

Comment 4

[Tooru Fujisawa [:arai]]

Thanks!
filed https://github.com/mozilla-spidermonkey/jsparagus/issues/434

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/e6daf3c4a812