1625500 - Tell people to use `.finally()` instead of `.then(foo, foo)` when `foo` is the same thing for both arguments

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Lint and Formatting, task)

Description

[:Gijs (he/him)]

I didn't actually realize this existed (and it is several years newer than .then!). It's neat, we should be using it.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1625500 - tell people to use promise.finally() instead of passing 2 identical things to .then, r?Standard8

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1625500 - fix use of .then(x, x) in the tree, r?Standard8

Depends on D68613

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a35b13dfcde
tell people to use promise.finally() instead of passing 2 identical things to .then, r=Standard8
https://hg.mozilla.org/integration/autoland/rev/7d80233bcfcd
fix use of .then(x, x) in the tree, r=marionette-reviewers,Standard8,whimboo

Comment 4

[Cristina Coroiu [:ccoroiu]]

Backed out 2 changesets (bug 1625500) for multiple failures

Backout: https://hg.mozilla.org/integration/autoland/rev/30da2d82fd66f1739c32b4c4be102c46181b8e03

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7d80233bcfcd48ae82209aacec29dadc93a49cb2

Failure logs:
xpcshell:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298087559&repo=autoland&lineNumber=2521
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298085810&repo=autoland&lineNumber=3013
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298085507&repo=autoland&lineNumber=1427
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298085516&repo=autoland&lineNumber=1537
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298085448&repo=autoland&lineNumber=11696
devtools:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298087547&repo=autoland&lineNumber=6879
bc failures:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298087290&repo=autoland&lineNumber=11141

Comment 5

[:Gijs (he/him)]

Talked to Mark, going to split up the fixing patch because not all consumers here like being switched to .finally(), as we no longer catch rejections that way.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:Gijs, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[:Gijs (he/him)]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #6)

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:Gijs, could you have a look please?
For more information, please visit auto_nag documentation.

Thanks for reminding me how busy I am, bugbug.

Comment 8

[:Gijs (he/him)]

I think the subtle differences here are annoying enough that this isn't worth doing.