Handle onMayChangeProcess within DocumentLoadListener
Categories
(Core :: DOM: Navigation, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
(Blocks 1 open bug)
Details
Attachments
(6 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
When I first added this method last year, I added it in JS, handled from within SessionStore.jsm, as that was the easiest place to do it. Now that DocumentLoadListener exists, it makes more sense to handle this logic directly from within that code.
Many parts of the process switch are still handled by frontend JS, such as selecting remote types, and performing toplevel process switches.
|
Assignee | |
Comment 1•4 years ago
|
||
When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.
Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a78ae89b25b6 Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh https://hg.mozilla.org/integration/autoland/rev/64dfd2e32a7b Part 2: Completely remove nsIProcessSwitchRequestor, r=mattwoodrow
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3fa982490ebc Backed out 2 changesets for causing several reftest failures. CLOSED TREE
|
||
Comment 5•4 years ago
|
||
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=64dfd2e32a7bb5b0a3922d63f10c21ee21822b85&selectedJob=296449593
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=296449593&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296452750&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296449552&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/3fa982490ebc
There are also these unexpected passes: https://treeherder.mozilla.org/logviewer.html#?job_id=296450509&repo=autoland
Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/69f75d37ae8e Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh https://hg.mozilla.org/integration/autoland/rev/876b33334577 Part 2: Completely remove nsIProcessSwitchRequestor, r=mattwoodrow
|
||
Comment 7•4 years ago
•
|
||
Backed out 2 changesets (bug 1625513) for bc failures in browser/base/content/test/siteIdentity/browser_identity_UI.js
and also for wr tier 2 failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=wr%2CLinux%2C18.04%2Cx64%2CQuantumRender%2Cdebug&fromchange=b70c2c720c4d7aa6572f72fd62112d52c2dd2d71
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296844209&repo=autoland&lineNumber=15787
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296854579&repo=autoland&lineNumber=16855
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296854653&repo=autoland&lineNumber=1340
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296854665&repo=autoland&lineNumber=19538
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296854607&repo=autoland&lineNumber=7722
Backout:https://hg.mozilla.org/integration/autoland/rev/04c31e994f29e72dd81a7340100d12f67e48a5b4
|
|
Assignee | |
Comment 8•4 years ago
|
||
|
|
Assignee | |
Comment 9•4 years ago
|
||
|
||
Comment 10•4 years ago
|
||
Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f2dbff5d584f Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh,necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/ad09a911bc43 Part 2: Completely remove nsIProcessSwitchRequestor, r=mattwoodrow,necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/3554e0be2e66 Part 3: Allow importing a named object from a module with do_ImportModule, r=kmag https://hg.mozilla.org/integration/autoland/rev/0366bbc9e0f7 Part 4: Don't require being in tabbrowser for subframe process switches, r=mattwoodrow,necko-reviewers,valentin
|
||
Comment 11•4 years ago
|
||
Backed out 4 changesets (Bug 1625513) for causing assertion in WindowGlobalChild.cpp
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298462976&repo=autoland&lineNumber=14266
Backout: https://hg.mozilla.org/integration/autoland/rev/147908a741ba7dc1c1bd06d5e7ff225d119a07e2
|
|
Assignee | |
Comment 12•4 years ago
|
||
|
|
||
Comment 13•4 years ago
|
||
Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24a646225c68 Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh,necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/8c235f0f967c Part 2: Completely remove nsIProcessSwitchRequestor, r=mattwoodrow,necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/cc19c74910d1 Part 3: Allow importing a named object from a module with do_ImportModule, r=kmag https://hg.mozilla.org/integration/autoland/rev/8ac6db819435 Part 4: Don't require being in tabbrowser for subframe process switches, r=mattwoodrow,necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/88ac5d853e38 Part 5: Don't run sandboxed srcdoc loads through DocumentChannel, r=mattwoodrow
|
|
||
Comment 14•4 years ago
|
||
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ebdaa3ce92a1 Backed out 5 changesets for bc failures on browser_identity_UI.js. CLOSED TREE
|
|
Assignee | |
Comment 15•4 years ago
|
||
|
|
||
Comment 16•4 years ago
|
||
Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4efd3837591 Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh,necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/3414bb38c838 Part 2: Completely remove nsIProcessSwitchRequestor, r=mattwoodrow,necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/109d94762b97 Part 3: Allow importing a named object from a module with do_ImportModule, r=kmag https://hg.mozilla.org/integration/autoland/rev/b6b78f4c0a2a Part 4: Don't require being in tabbrowser for subframe process switches, r=mattwoodrow,necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/d53fb901d3b1 Part 5: Don't run sandboxed srcdoc loads through DocumentChannel, r=mattwoodrow https://hg.mozilla.org/integration/autoland/rev/c682ecac3b25 Part 6: Re-set the LOAD_DOCUMENT_URI flag in TriggerRedirectToRealChannel, r=mattwoodrow
|
||
Comment 17•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e4efd3837591
https://hg.mozilla.org/mozilla-central/rev/3414bb38c838
https://hg.mozilla.org/mozilla-central/rev/109d94762b97
https://hg.mozilla.org/mozilla-central/rev/b6b78f4c0a2a
https://hg.mozilla.org/mozilla-central/rev/d53fb901d3b1
https://hg.mozilla.org/mozilla-central/rev/c682ecac3b25
|
|
Assignee | |
Updated•4 years ago
|
Description
•