1625513 - Handle onMayChangeProcess within DocumentLoadListener

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement, P3)

Description

[Nika Layzell [:nika] (ooo, ni? for response)]

When I first added this method last year, I added it in JS, handled from within SessionStore.jsm, as that was the easiest place to do it. Now that DocumentLoadListener exists, it makes more sense to handle this logic directly from within that code.

Many parts of the process switch are still handled by frontend JS, such as selecting remote types, and performing toplevel process switches.

Comment 1

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1625513 - Part 1: Perform onMayChangeProcess handling within DocumentLoadListener,

When I first added this method last year, I added it in JS, handled from within
SessionStore.jsm, as that was the easiest place to do it. Now that
DocumentLoadListener exists, it makes more sense to handle this logic directly
from within that code.

Many parts of the process switch are still handled by frontend JS, such as
selecting remote types, and performing toplevel process switches.

Comment 2

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1625513 - Part 2: Completely remove nsIProcessSwitchRequestor,

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a78ae89b25b6
Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh
https://hg.mozilla.org/integration/autoland/rev/64dfd2e32a7b
Part 2: Completely remove nsIProcessSwitchRequestor, r=mattwoodrow

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fa982490ebc
Backed out 2 changesets for causing several reftest failures. CLOSED TREE

Comment 5

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=64dfd2e32a7bb5b0a3922d63f10c21ee21822b85&selectedJob=296449593

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=296449593&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296452750&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=296449552&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/3fa982490ebc

There are also these unexpected passes: https://treeherder.mozilla.org/logviewer.html#?job_id=296450509&repo=autoland

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69f75d37ae8e
Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh
https://hg.mozilla.org/integration/autoland/rev/876b33334577
Part 2: Completely remove nsIProcessSwitchRequestor, r=mattwoodrow

Comment 7

[Oana Pop-Rus]

Backed out 2 changesets (bug 1625513) for bc failures in browser/base/content/test/siteIdentity/browser_identity_UI.js

and also for wr tier 2 failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=wr%2CLinux%2C18.04%2Cx64%2CQuantumRender%2Cdebug&fromchange=b70c2c720c4d7aa6572f72fd62112d52c2dd2d71

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&fromchange=b70c2c720c4d7aa6572f72fd62112d52c2dd2d71&searchStr=linux%2C18.04%2Cx64%2Cquantumrender%2Cdebug%2Cweb%2Cplatform%2Ctests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-web-platform-tests-reftest-fis-e10s-6%2Cw-fis%28wr6%29&tochange=04c31e994f29e72dd81a7340100d12f67e48a5b4

and /acid/acid2/reftest.html :
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=linux%2C18.04%2Cx64%2Cquantumrender%2Cdebug%2Cweb%2Cplatform%2Ctests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-web-platform-tests-reftest-fis-e10s-4%2Cw-fis%28wr4%29&tochange=2b02e71f1780572d0131ce8706d19c05b19740d7&fromchange=b70c2c720c4d7aa6572f72fd62112d52c2dd2d71

and reftest failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&fromchange=f39a87ff23d8be6d86e919748f4585397d52e374&searchStr=linux%2C18.04%2Cx64%2Cquantumrender%2Cdebug%2Creftests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64-qr%2Fdebug-reftest-fis-e10s-7%2Cr-fis%28r7%29&tochange=2b02e71f1780572d0131ce8706d19c05b19740d7

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&fromchange=f39a87ff23d8be6d86e919748f4585397d52e374&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-fis-e10s-10%2Cm-fis%28bc10%29&selectedJob=296844209

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296844209&repo=autoland&lineNumber=15787
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296854579&repo=autoland&lineNumber=16855
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296854653&repo=autoland&lineNumber=1340
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296854665&repo=autoland&lineNumber=19538
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296854607&repo=autoland&lineNumber=7722

Backout:https://hg.mozilla.org/integration/autoland/rev/04c31e994f29e72dd81a7340100d12f67e48a5b4

Comment 8

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1625513 - Part 3: Allow importing a named object from a module with do_ImportModule,

Comment 9

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1625513 - Part 4: Don't require being in tabbrowser for subframe process switches,

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2dbff5d584f
Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/ad09a911bc43
Part 2: Completely remove nsIProcessSwitchRequestor, r=mattwoodrow,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/3554e0be2e66
Part 3: Allow importing a named object from a module with do_ImportModule, r=kmag
https://hg.mozilla.org/integration/autoland/rev/0366bbc9e0f7
Part 4: Don't require being in tabbrowser for subframe process switches, r=mattwoodrow,necko-reviewers,valentin

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1625513) for causing assertion in WindowGlobalChild.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=0366bbc9e0f70926b6a52681429698742ca62da0&searchStr=reftest&selectedJob=298483580

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298462976&repo=autoland&lineNumber=14266

Backout: https://hg.mozilla.org/integration/autoland/rev/147908a741ba7dc1c1bd06d5e7ff225d119a07e2

Comment 12

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1625513 - Part 5: Don't run sandboxed srcdoc loads through DocumentChannel,

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24a646225c68
Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/8c235f0f967c
Part 2: Completely remove nsIProcessSwitchRequestor, r=mattwoodrow,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/cc19c74910d1
Part 3: Allow importing a named object from a module with do_ImportModule, r=kmag
https://hg.mozilla.org/integration/autoland/rev/8ac6db819435
Part 4: Don't require being in tabbrowser for subframe process switches, r=mattwoodrow,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/88ac5d853e38
Part 5: Don't run sandboxed srcdoc loads through DocumentChannel, r=mattwoodrow

Comment 14

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebdaa3ce92a1
Backed out 5 changesets for bc failures on browser_identity_UI.js. CLOSED TREE

Comment 15

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1625513 - Part 6: Re-set the LOAD_DOCUMENT_URI flag in TriggerRedirectToRealChannel,

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4efd3837591
Part 1: Perform onMayChangeProcess handling within DocumentLoadListener, r=mattwoodrow,pbone,droeh,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/3414bb38c838
Part 2: Completely remove nsIProcessSwitchRequestor, r=mattwoodrow,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/109d94762b97
Part 3: Allow importing a named object from a module with do_ImportModule, r=kmag
https://hg.mozilla.org/integration/autoland/rev/b6b78f4c0a2a
Part 4: Don't require being in tabbrowser for subframe process switches, r=mattwoodrow,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/d53fb901d3b1
Part 5: Don't run sandboxed srcdoc loads through DocumentChannel, r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/c682ecac3b25
Part 6: Re-set the LOAD_DOCUMENT_URI flag in TriggerRedirectToRealChannel, r=mattwoodrow

Comment 17

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/e4efd3837591
https://hg.mozilla.org/mozilla-central/rev/3414bb38c838
https://hg.mozilla.org/mozilla-central/rev/109d94762b97
https://hg.mozilla.org/mozilla-central/rev/b6b78f4c0a2a
https://hg.mozilla.org/mozilla-central/rev/d53fb901d3b1
https://hg.mozilla.org/mozilla-central/rev/c682ecac3b25