1625531 - Thunderbird Crash in [@ mozilla::EditorBase::IsSelectionRangeContainerNotContent] via mozilla::HTMLEditor::GetParagraphState

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[Wayne Mery (:wsmwk)]

Currently #3 crash for Thunderbird daily. Based on the stats, the average user crashes only once. I looked at 5 crashes and there are no common add-ons, and some have no add-ons.

The very first crash is buildid 20200310101724 bp-0188ca84-1262-4a7f-8fa1-b9e110200310.

Top 10 frames of crashing thread:

0 xul.dll mozilla::EditorBase::IsSelectionRangeContainerNotContent const editor/libeditor/EditorBase.cpp:5472
1 xul.dll mozilla::HTMLEditor::GetParagraphState editor/libeditor/HTMLEditor.cpp:1857
2 xul.dll XPTC__InvokebyIndex 
3  @0x89d307 
4 xul.dll static XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1141
5 xul.dll XPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:947
6 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:569
7 xul.dll InternalCall js/src/vm/Interpreter.cpp:632
8 xul.dll Interpret js/src/vm/Interpreter.cpp:3046
9 xul.dll js::RunScript js/src/vm/Interpreter.cpp:449

Comment 1

[Magnus Melin [:mkmelin]]

A little more recent, bp-4b6a76b3-1f99-4e24-9b02-0f9470200327 crash at https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/editor/libeditor/EditorBase.cpp#5812 I guess SelectionRefPtr() is null there for some reason.

Comment 2

[Geoff Lankow (:darktrojan)]

I suspect this has something to do with bug 1613534, but I don't see any crashes on beta.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1625531 - Make `HTMLEditor::GetParagraphState()` not check selection r=m_kato!

The selection validation should be checked in the constructor of
ParagraphStateAtSelection because
EditorBase::IsSelectionRangeContainerNotContent() needs edit action data.

Additionally, this patch adds a test for nsIHTMLEditor.getParagraphState().

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/514f5fc3d977
Make `HTMLEditor::GetParagraphState()` not check selection r=m_kato

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/514f5fc3d977